Repository navigation
Reject destination name changes after verification - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A destination file could be replaced with different bytes of the same size after Standard verification and before final coverage. The final check previously compared only pathname and size, leaving the saved row verified even though that pathname now referred to a different file.
Recheck each selected final name through a read-only, no-follow directory walk and compare its identity with the file that supplied readback bytes. A mismatch or failed recheck replaces the verified row with an explicit failure and does not emit completed progress. Also check the current name when a pinned read finishes, which matters on filesystems with weak change-time metadata. Quick mode remains copied-unverified.
Validation:
success && verificationResult.isValid. Mid-read APFS substitution was already rejected by the existing pinned-file stability check.SharedSelectionTests.coordinatorIsAnalysingRightAfterASourceIsChosenandOperationStateSingleSourceTests.automaticPausePausesTheEngine). Both passed together when run focused. These were not established as main-branch regressions; the serial full suite passed.No release is included. The separate exFAT/FAT publication redesign is outside this PR.