Repository navigation
Add opt-in streaming memory probes - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These Mac engine tests exercise two streaming paths with disposable 512 MiB sparse files and sample the process's physical memory footprint. The Standard copy probe uses the real fan-out writer with one and two destinations, checks bytes written and output sizes, and fails if footprint grows by 128 MiB or more. A separate probe checks the byte-comparison path used by Paranoid folder Compare. Missing footprint samples fail the tests instead of silently passing.
Both tests skip in normal runs. Run each alone with
BITMATCH_COPY_MEMORY_TEST=1orBITMATCH_COMPARE_MEMORY_TEST=1and the matchingStreamingMemoryProbeTeststest filter.On the current branch, copy measured 6→10 MiB with one destination and 10→10 MiB with two; byte comparison measured 5→14 MiB over 128 progress callbacks. Both isolated probes passed. These are bounded-memory checks for these paths, not a reproduction or explanation of issue #23. Sparse APFS input, an engine test process, and direct calls to the writer/comparer do not cover the reporter's media, full app workflow, destination verification, MHL, or reports.
Local validation: both opt-in probes passed again after rebasing onto main
feb06db5; the full engine gates passed on the immediately preceding main3f43fc85(XCTest: 148 tests, 19 skipped, zero failures; Swift Testing: 181 tests in 34 suites). The Mac app test suite passed onfeb06db5(** TEST SUCCEEDED **). The normal engine suites skip these opt-in probes; the separate focused runs above executed them.