Repository navigation
Fix notification feedback and menu-bar icons; prepare 0.2.10 - #65
Merged
Merged
Conversation
Base automatically changed from
fix/queue-expected-exclusions-20261020
to
main
October 20, 2026 11:31
mikecerisano
changed the base branch from
fix/queue-expected-exclusions-20261020
to
main
October 20, 2026 11:31
mikecerisano
marked this pull request as ready for review
October 20, 2026 11:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification permission failures were silently discarded, leaving Enable Notifications looking unresponsive. Settings now shows pending/failure feedback, prevents overlapping requests, and opens the running app’s notification settings. iPhone and iPad Settings also provide Enable Notifications.
The native walkthrough also found a missing Mac menu-bar icon. The label now supplies an 18 pt template image with bounded progress states and a thread-safe drawing callback; the companion scene uses explicit insertion. Mike confirmed the rebuilt icon, menu and Open BitMatch action work. This prepares 0.2.10/build 20.
Local validation: final Mac suite 1,314 passed/23 skipped/zero failures; iPad and iPhone each 75 passed/10 skipped; both engine frameworks in Debug and Release; iOS device Release build; eight offline updater tests. Engine/mobile inputs remained unchanged after the Mac-only icon correction. The replacement universal Mac app and DMG are signed, notarized, stapled and accepted by Gatekeeper; independent mounted-DMG checks matched the archived app.
The physical SD → T9 + WheeDrive walkthrough verified all six selected copies, preserved all six source files, and validated both MHL histories and the PDF/CSV/JSON/checksum reports. Expected AppleDouble exclusions remained disclosed and the queue ended without pausing. Native checks covered notification authorization, compact import Cancel/Apply, saved settings, Copying → Finishing → final results, and menu status/Open. Active-window hide/Quit and physical mobile-provider/background checks remain separate follow-ups. Validation and limits.
GitHub’s older-compiler failures are documented separately from the passing local shipping-toolchain tests. This release does not establish the causes of issues #10 or #23.