Repository navigation
Fix DDR5 SPD misidentification as DDR4 - #12
Open
chenx-dust wants to merge 1 commit into
Open
chenx-dust wants to merge 1 commit into
chenx-dust wants to merge 1 commit into
Conversation
Owner
|
Thank you for your PR. |
Author
I understand. However, the bug fixed by this PR is a critical issue that incorrectly identifies DDR5 memory as DDR4, which has affected the proper operation of downstream applications, e.g. librehardwaremonitor. I hope this issue can be resolved as soon as possible. Thank you! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DDR5 hubs expose their device revision at offset 0x02, where DDR4 EEPROMs store the memory type. A revision such as 0x10 can therefore be mistaken for LPDDR4 by the DDR4-first detection path.
Extract the existing SPD5118 identity check into a shared read-only helper and use it to exclude DDR5 hubs from DDR4 detection. Verify the hub identity before DDR5 page selection to avoid treating a non-DDR5 EEPROM byte as MR11. Keep the existing detection order, retry logic, and failure logging.
Assisted by GPT 6 Astra