bugfix(jobStatusPage): stop layer jump on Z-hop + harden print-stats slots#258
Merged
Conversation
HugoCLSC
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select the type:
Follow-up hardening for the
jobStatusPagelayer logic introduced in #208. Fixes a field-observed bug where the current-layer counter jumped whenever the toolhead raised Z (travel moves / Z-hop) to reach another region of the plate, and aligns the layer-source priority with Mainsail's getters.print_stats.info.total_layer(orcurrent_file.layer_count) is no longer overwritten by the geometry estimate, matching Mainsail'sgetPrintMaxLayerspriority.on_flowguard_update: renamed params that shadowed thestr/dictbuiltins, added type hints, and applied each key independently so a partial delta no longer raisesKeyError.handleCancel: replaced the disconnect+reconnect dance with a singleUniqueConnection(guarded) connect.showEvent: now callssuper().showEvent().toggle_thumbnail_expansion, merged the duplicate valid-state branch in_handle_print_state, and tidied the print-stats dispatch.Motivation
The Z-based layer fallback read the instantaneous
gcode_move.gcode_position[2], so any non-print Z motion (Z-hop, travel to a taller area) was interpreted as a layer change and the counter flickered. Sincegcode_positionis published on essentially every move, a two-sample "Z settled" filter reliably distinguishes a real layer advance from a transient hop while keeping the counter monotonic.The layer-source priority was also corrected to match Mainsail so a reported total layer count is never clobbered by the geometry estimate.
Tests
New/updated cases: transient Z-hop does not bump the layer, layer never regresses, reported
total_layernot overridden by estimate, flowguard partial vs full payload, plus the two-sample settle behavior.