bugfix/layer progress mainsail parity#280
Merged
Merged
Conversation
HugoCLSC
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select the type:
Fixes the layer-count and progress-bar behaviour reported from the field. Follow-up to #269 and #272, whose stateless-layer approach did not hold on device.
pausedstate, released onprinting) so the Happy Hare park Z-lift no longer bumps it to a bogus value.getPrintPercentByFilepositionRelative): clip file position togcode_start_byte/gcode_end_byte, so start macros read 0% and the tail matches Mainsail; falls back to rawvirtual_sdcard.progress.CustomProgressBar.setValue(float)(incompatible override, wrong 0-100 bound) with a clampedset_progress(fraction)and add a realreset()that clears the painted value.Motivation
Progress used raw absolute file position, so start-print macros (mesh/plate calibration) showed ~4% and the end diverged from Mainsail.The pause layer jump and the stale/blank layer readouts came from the reset living only in the screen-initiated path and from Z-fallback recompute racing the pause state update.
Tests
11 new unit tests in
test_job_status_page_unit.py, plus newtest_progress_bar_unit.py).