Add BIP39 word-number mnemonic entry#312
Open
oroderico wants to merge 3 commits into
Open
Conversation
added 3 commits
July 18, 2026 14:42
Text nodes can display sensitive wallet data. Use wally_free_string() when replacing their contents so the old allocation is cleared before release, matching the text-node destructor.
Allow digit-entry callers to select a shorter field width and an optional maximum value while preserving the existing six-digit PIN and index defaults. Skip unavailable candidate digits during navigation and keep short-number entry semantics unchanged.
Allow advanced 12- and 24-word recovery to use one-based BIP39 word numbers. Resolve and confirm every word, retain the existing final-word calculation flow, and validate the complete recovery phrase before deriving keys. Clear sensitive entry state and displayed words when the flow exits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This implements the flow agreed in #311, including the
Entry Methodtitle and theWord/Index Numberoptions. Thanks to @jgriffiths for routing the proposal to the product team, and to @bitcoinhelp for the product feedback and confirmation of the updated flow.Closes #311.
Implementation
Testing
clang-format --dry-run --Werrorandgit diff --check