Added list for events subscription configuration#2
Open
EduardMikhrin wants to merge 10 commits into
Open
Conversation
Co-authored-by: Oleg Fomenko <oleg.fomenko2002@gmail.com>
olegfomenko
approved these changes
Jul 22, 2026
Co-authored-by: Oleg Fomenko <oleg.fomenko2002@gmail.com>
Nazarevsky
requested changes
Jul 23, 2026
Nazarevsky
left a comment
Nazarevsky
left a comment
Member
There was a problem hiding this comment.
Thank you @EduardMikhrin and @olegfomenko for your changes. Everything seems to look good to me. Nice intention on adding an ability of providing different config paths as well as tests for it.
Found just a tiny nit - ENV_EVENTS_VAR is not used. I believe it is just slipped, isn't it? Overall, we can merge it
|
|
||
| const ENV_PREFIX: &str = "EVENT_PLUGIN"; | ||
| const ENV_CONFIG_VAR: &str = "EVENT_PLUGIN_CONFIG"; | ||
| const ENV_EVENTS_VAR: &str = "EVENT_PLUGIN_EVENTS"; |
Member
There was a problem hiding this comment.
This one seems to be unused. Do we need it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.