Skip to content

Merge ROS2 SLAM/NAV integration branch to develop - #194

Merged
jonpg01 merged 12 commits into
developfrom
feature/ros2_slam_nav_int
Aug 27, 2026
Merged

jonpg01 merged 12 commits into
developfrom
feature/ros2_slam_nav_int

Conversation

@jonpg01

@jonpg01 jonpg01 commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@stefanvogel
stefanvogel removed their request for review August 18, 2026 08:38
@stefanvogel stefanvogel changed the title Feature/ros2 slam nav int Merge ROS2 SLAM/NAV integration branch to develop Aug 18, 2026
Comment thread webots/worlds/zumo_with_flag_ship/DcsMinimalLidarExample.wbt

@FelixReite FelixReite left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question regarding the synchronization setup. Otherwise, the changes look good to me.

@jonpg01
jonpg01 requested a review from FelixReite August 27, 2026 07:54
Comment thread webots/worlds/zumo_with_flag_ship/DcsMinimalLidarExample.wbt Outdated
@jonpg01
jonpg01 requested a review from FelixReite August 27, 2026 08:51
stefanvogel and others added 12 commits August 27, 2026 10:57
* fix(APPRemoteControl): clamp angular setpoint and supervise SMP connection from startup
* chore: remove default PIO envs
* docs: fix typo
…slot is missing or taken

Before this change, launching via webots-controller would segfault with no
useful output if the target robot had no extern controller slot in the loaded
world, or if the slot was already claimed by another controller (e.g. DCS
holding ZumoComSystem).

Add a preflight check that probes each required IPC socket before invoking
webots-controller. The check distinguishes three failure cases: Webots not
running, wrong world loaded (slot absent), and slot already taken by another
controller. All three now produce a descriptive error listing available slots.
Co-authored-by: Stefan <stefan.vogel@newtec.de>
@jonpg01
jonpg01 force-pushed the feature/ros2_slam_nav_int branch from df960c9 to 3cfdb69 Compare August 27, 2026 09:04
@jonpg01
jonpg01 merged commit 8cacfe8 into develop Aug 27, 2026
47 checks passed
@stefanvogel
stefanvogel deleted the feature/ros2_slam_nav_int branch August 27, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants