ENH: Add Use Feature Ids option to ComputeKernelAvgMisorientations#1674
Open
imikejackson wants to merge 11 commits into
Open
ENH: Add Use Feature Ids option to ComputeKernelAvgMisorientations#1674imikejackson wants to merge 11 commits into
imikejackson wants to merge 11 commits into
Conversation
* Add use_feature_ids BoolParameter (default true keeps the original per-grain behavior) * When false, KAM is computed per-voxel: kernel neighbors contribute if featureId > 0 and their phase matches the central cell, allowing the average to cross feature boundaries * Bump parametersVersion to 2 * Add Class 1 analytical test for the per-voxel mode Fixes BlueQuartzSoftware#1613 Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
* Two-phase fixture verifies per-voxel neighbor gates: different-phase and featureId=0 neighbors are excluded; featureId=0 focal cells still output 0 * Mode-equivalence invariant: per-grain and per-voxel modes are bit-identical on single-feature single-phase data Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
* Add use_feature_ids (true) and bump parameters_version to 2 in the three pipelines that use the filter Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
…ations Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
* Reopen report for issue BlueQuartzSoftware#1613 feature; re-enumerate code paths for the per-mode neighbor gates and map them to the new TEST_CASEs * Record 6.5.171 A/B results on the default per-grain path * Add deviation entry: per-voxel mode is an NX-only capability Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
* Fix signed legacy-vs-nx split to the recomputed values * Reconcile ctest entry count and refresh the exemplar-archive row for the reopened 9-path enumeration Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
* Reconcile code-path exercised count (9 enumerated, 8 exercised) * Record A/B input generator seed and recipe for reproducibility * Clarify per-voxel phase-gate rationale in user documentation Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
* Use getDataRefAs for the parameter-validated ImageGeom (two sites) * Make kernel boundary clamps signed and compute the neighbor index from the clamped indices, removing the vacuous negative checks * Build the LaueOps list once per run as a worker member * Check cancellation per row instead of per plane * Floor the progress increment at 1 for thin chunk ranges * Remove the unreachable numVoxel == 0 fallback and fold the invalid-cell reset into an else branch * Replace placeholder Doxygen with real class documentation Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
* Note Image Geometry requirement and degree units; link related misorientation filters * Re-cite shifted line numbers; path enumeration now 8 of 8 after the dead numVoxel fallback was removed Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
The section (path-to-TEST_CASE mapping table) was dropped accidentally during a commit amend before push. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
imikejackson
force-pushed
the
topic/kam_ignore_feature_ids
branch
from
July 16, 2026 18:07
785d491 to
503ef1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
use_feature_idsboolean parameter (default: true) to the Compute Kernel Average Misorientations filter.parametersVersion()bumped 1 → 2; the three shipping pipelines that use the filter are migrated; SIMPL-converted and older NX pipelines pick up the default via argument backfill.getDataRefAsfor the validated geometry, signed kernel boundary clamps with the neighbor index computed from the clamped indices, LaueOps list built once per run, per-row cancel checks, progress-increment floor, removal of the unreachablenumVoxel == 0fallback, and real Doxygen. All behavior-preserving.Fixes #1613
Test Plan