Repository navigation
feat(EmbedPDF): update EmbedPDF to v3.3.0 - #1313
Merged
Merged
Conversation
Refresh official self-hosted runtime assets and bump the component to 11.0.2. Fixes #1312 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Sorry @ArgoZhang, your pull request is larger than the review limit of 150,000 diff characters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #1312
Summary By Copilot
Upgrade the self-hosted EmbedPDF runtime from v3.2.0 to v3.3.0 (latest stable release, published 2026-11-16), bump
BootstrapBlazor.EmbedPDFfrom 11.0.1 to 11.0.2, and update the bundled-assets readme.Replace the official runtime JavaScript chunks, worker, and WASM together; remove obsolete hashed chunks. All 105 runtime files are byte-identical to the official
embedpdf-viewer-dist.zip(SHA-25601ce575224eab0b292ed680cb95cb3418ecea62ca5df345c2af037fc3a1578dc). Follow the existing vendoring convention: no npm rebuild, source maps, or declaration files are added.Upstream release: https://github.com/embedpdf/embed-pdf-viewer/releases/tag/v3.3.0
The existing Blazor API and JS adapter remain unchanged. The release adds stamp libraries, signature timestamps/long-term validation, and invisible form-widget fixes. Signature verdicts now account for trusted timestamps and revocation evidence; newly added cloud signature operations need a 3.3 server, but this component uses the local engine and exposes no cloud-specific API. Existing v3.0.0/v3.2.0 upgrades #1279 and #1297 are already merged; this is a new branch based on current master.
Regression?
Risk
Third-party viewer/worker/WASM update, including upstream signature-validation behavior changes. No wrapper API changes. Runtime files are preserved exactly as distributed rather than edited or reformatted.
Verification
Browser smoke verification used the actual repository
EmbedPDF.razor.js, official viewer, local worker and WASM, and a generated three-page PDF. Only Bootstrap's data/event/module-registration dependencies were minimal test doubles; this is not a full hosted Blazor demo test. Visually confirmed page 2 renders. Browser assertions passed for initial readiness, page count,CurrentPage=2, vertical/horizontal layouts, URL replacement closing the active document,IsKeepCurrentDocumentretaining both documents, active-document layout, light/dark/system themes, Bootstrap theme events, Chinese locale loading, disposal, and disposal while initialization is pending. No viewer errors during these assertions. The desktop Browser host separately emitted an unrelated notification-permission ACL warning during initial page startup.Automated archive checksum and byte comparison passed for all 105 runtime assets, with no stale/missing runtime files. Local WASM HTTP response: 200, 7,889,371 bytes.
Commands and results:
git diff --cached --check -- src/components/BootstrapBlazor.EmbedPDF/BootstrapBlazor.EmbedPDF.csproj src/components/BootstrapBlazor.EmbedPDF/wwwroot/readme.txt— passed before commit.git diff --cached --check— reports upstream whitespace in the generated main chunk (including PDF cross-reference string literals); intentionally preserved for byte-identical vendoring.dotnet build src/components/BootstrapBlazor.EmbedPDF/BootstrapBlazor.EmbedPDF.csproj --no-restore --verbosity quiet— blocked by the existing local SDK installation:MSB4018, missingMicrosoft.Deployment.DotNet.Releases.dllin .NET SDK11.0.100-rc.2.26504.105, before component compilation.dotnet build src/components/BootstrapBlazor.EmbedPDF/BootstrapBlazor.EmbedPDF.csproj -f net11.0 --no-restore --verbosity quiet— same SDK failure. Build binlog replay confirmed the missing SDK assembly. Shared SDK/global.json were not modified. Full component .NET build/pack and hosted Blazor verification remain unverified.gh pr checks 1313 --repo BootstrapBlazor/BootstrapBlazor.Extensions --watch --interval 10— passed:run testandauto approvesucceeded; Sourcery skipped. The PR CI run runsdotnet test test/UnitTestEditor, which passed; it is not a substitute for the component-specific build blocked locally above.Packaging changes reviewed?
Reviewed bundled static-resource inventory against the official archive; retained local worker/WASM paths and bumped package version. NuGet pack could not run because of the SDK limitation above.
☑️ Self Check before Merge