Skip to content

Mobile drawer: Computers and Cloud tabs with one Add entry #2174

Closed

Description

@DoodleBears

Final user-approved behavior

  • Top of the left drawer contains Computers / Cloud rounded tabs only; no redundant Workspaces title or close button.
  • One plus action immediately below tabs: Computers opens computer pairing; Cloud opens invitation URL/QR join. The earlier mixed Add chooser and stacked decorative icons were explicitly superseded.
  • Independent middle list: first line is a name, second line a small service/computer address. Default text uses at most two lines; accessibility text may wrap. Channel-only guests retain scoped organization identity without gaining membership.
  • Fixed footer: Notifications in both tabs; Manage cloud services in Cloud. Organization creation stays in the management flow.
  • Optional local connection names during pairing/import and later editing. Cloud renaming preserves trusted connection/session fields; Computer names use the existing local appearance store.
  • Preserve swipe/backdrop/Back/accessibility escape, existing account authority and guest-only channel access.

Delivery and evidence

Implemented in #2175, folded into #2172, with main integration through #2170. Final code dc15ffd3a, screenshots 380085173; full exact-source limits and 13 rendered screenshots are in #2175. iOS checks cover both tabs/contextual destinations, three text sizes × light/dark, independent list scrolling and fixed footer. Cloud rename/save/cold restart/restore passed; Computer input was tested without redeeming a pairing.

The Human authorized the stack merge on 2026-10-18 after tests/CI. This issue closes only after the final main integration. Remaining device/navigation acceptance is explicitly tracked in #2186, not silently counted as passed. No production deployment.

Activity

  1. DoodleBears commented on Oct 18, 2026

    @DoodleBears
    ContributorAuthor

    Agent work claim

    • Agent: Codex
    • Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9 (not a DSH Session)
    • Issue scope: two drawer tabs and one Add chooser; reuse existing invite/pair/manage routes.
    • Branch: codex/2174-drawer-tabs
    • Started: 2026-10-18
    • State: active
  2. added
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Oct 18, 2026
  3. DoodleBears commented on Oct 18, 2026

    @DoodleBears
    ContributorAuthor

    Agent work outcome

  4. removed
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Oct 18, 2026
  5. DoodleBears commented on Oct 18, 2026

    @DoodleBears
    ContributorAuthor

    Native screenshot follow-up

    • PR feat(mobile): compact workspace drawer with contextual actions and local names #2175 now embeds eight actual iOS Simulator screenshots: matched light/dark before and after (Computers and Cloud), plus the new Add chooser in both themes. Browser readback verified all eight images loaded at 402 × 874.
    • Source 6292fbf41123bc583f813116e349ac2788e3871a, integrated batch 06c92fc78b71643f6cdd74d42d50913ea92d640a, native 494a20f1eb4f0666a2c90bc3c758af4e7ff5f46b; evidence 59fc97fd7bada6d54cbae1feacc4d93d032e4c82 changes screenshots/docs only.
    • PASS: selected tab/list separation; one Add action; cancel returns to the same tab; Join reaches invitation link/QR page; Pair reaches existing pairing page. Maximum text wraps and the chooser scrolls/closes.
    • Not passed: after Pair presents a native modal, opening cloud-services inside that modal leaves Workspaces unable to show its drawer above the modal. Reopening a regular cloud-services route restores the drawer. This needs a separate navigation fix; its regression origin was not established here. No complete navigation/accessibility pass is claimed.
    • Android, physical phone, Human/VoiceOver, login and real invitation acceptance were not exercised. No new account/pairing/Host writes. Shared branch, light/large settings and driver/Metro were restored/released. PR stays Draft and unmerged; no Prod.
  6. DoodleBears commented on Oct 18, 2026

    @DoodleBears
    ContributorAuthor

    Agent work claim — requested simplification

    • Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
    • Branch: codex/2174-drawer-tabs; PR feat(mobile): compact workspace drawer with contextual actions and local names #2175
    • Scope: move Computers/Cloud tabs to the top, remove redundant Workspaces title/close row, remove the mixed Add chooser and stacked icons. Each tab's plus action goes directly to its existing pairing or cloud invitation route. Keep swipe/backdrop/Android Back and accessibility escape.
    • State: active
  7. added
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Oct 18, 2026
  8. DoodleBears commented on Oct 18, 2026

    @DoodleBears
    ContributorAuthor

    Agent work outcome — compact drawer and connection names

    • Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9; state: handed-off for Human review.
    • Draft PR feat(mobile): compact workspace drawer with contextual actions and local names #2175 now has top Computer/Cloud tabs, separate direct Add actions below tabs, compact name/address rows and a fixed Notifications footer. Optional connection names are local to the phone; cloud rename preserves trust/session fields and works offline.
    • Final source dc15ffd3a7003ef0c0f4110f834f02f15a990e6c; source CI passed. Evidence-only head 38008517393b0ff608d928826a5bbca3f00d3503 has a fresh CI run in progress. Typecheck and focused tests passed.
    • Native final layout: integrated 1376b50b1f8358d9d9b22c89e55901fb5a141d24, retained native 494a20f1eb4f0666a2c90bc3c758af4e7ff5f46b. Verified both tabs/contextual destinations, light/dark across default/intermediate/max text, left swipe, and middle-list scrolling with unchanged Notifications position. Native review caught a duplicate footer under the backdrop; it was removed and final screenshots recaptured.
    • Naming at f2d0f4af3 (identical naming code): cloud edit/save/cold-restart persistence and exact original-name restoration/readback passed; Computer input exercised without redeeming a pairing.
    • PR embeds 13 actual screenshots; browser confirmed every image loaded (402 × 874). Before/after share theme/locale/viewport/drawer fixture; exposed underlying route differs and is disclosed. Evidence and limits.
    • Remaining: Human review; Android/physical/VoiceOver; signed-in org/guest rows and actual named-computer pairing. Existing Pair-modal → cloud-services drawer-overlay caveat remains unqualified. Issue stays open, PR Draft/unmerged; no Prod.
    • Shared Simulator/Metro released; original cloud name, QA branch and display settings restored. No auth/Host writes, build or pairing redemption.
  9. added and removed
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Oct 18, 2026
  10. DoodleBears commented on Oct 18, 2026

    @DoodleBears
    ContributorAuthor

    Agent work outcome

    CodeRabbit had not returned its review at merge time; it was not counted as passed or as independent review approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions