Repository navigation
fix(messaging): leave this Bot's own apps out of Bind app (#1127) - #1130
Merged
Merged
Conversation
…llow again (#1109) The app's Conversations list in Edit identity sorts entries into Waiting, Active, Muted and Blocked. Mute admits silently, Rules reuses the group reception editor, Block revokes the entry, cancels unsent replies and writes a durable block per Bot, app fingerprint and conversation that survives restart and rebind; Allow again creates a fresh entry with no backfill. New conversations can be admitted automatically or held for the user, and new entries are bounded to 20 per hour and 500 active per app with at most 200 held. Issue: #1109 Agent-Task: claude-code/cloud/session_01WXjBatxGTRyRSxZYeJpqgH Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WXjBatxGTRyRSxZYeJpqgH
A Bot can now bind several apps of the same platform; one app still belongs to one Bot. Generation 63 drops messaging_binding_bot_platform and the bind and authorize commands no longer refuse a second app of a platform. A new apps projection lists every Provider account with its bound Bot; Bind app hides apps another Bot uses, External identities groups apps by platform, and Bot settings gets an IM apps list that refreshes on roster changes. Shared replies from a Bot with two apps in the same group refuse with reply-target-ambiguous. Issue: #1110 Agent-Task: claude-code/cloud/session_01WXjBatxGTRyRSxZYeJpqgH Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WXjBatxGTRyRSxZYeJpqgH
Per review, the app overview lives where apps are chosen. Bind app now lists every connected app: apps a Bot already uses are disabled and name that Bot (or say they are bound to this Bot), disconnected apps say so, and Manage app credentials opens IM bots settings. The IM apps list in Bot settings and its messagingApps bridge method are removed; the snapshot's accounts already carry the owner. Issue: #1110 Agent-Task: claude-code/cloud/session_01WXjBatxGTRyRSxZYeJpqgH Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WXjBatxGTRyRSxZYeJpqgH
They already show under External identities, so listing them again as "already bound to this Bot" was noise (real-IM QA finding). Issue: #1127 Agent-Task: claude-code/cloud/session_01WXjBatxGTRyRSxZYeJpqgH Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WXjBatxGTRyRSxZYeJpqgH
# Conflicts: # CHANGELOG.md # CHANGELOG.zh.md # packages/client/src/client/external-entries.tsx # packages/client/src/client/external-identity-list.tsx # packages/client/src/client/locale.ts # packages/client/test/external-identity-list.test.ts # packages/core/src/database/schema-plan.ts
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…apps # Conflicts: # docs/channel-sidebar/external-identities.md # docs/channel-sidebar/external-identities.zh.md # packages/client/src/client/external-identity-list.tsx # packages/client/src/client/locale.ts # packages/client/test/external-identity-list.test.ts
…apps # Conflicts: # CHANGELOG.md # CHANGELOG.zh.md # packages/client/src/client/external-identity-list.tsx # packages/client/test/external-identity-list.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Closes #1127 · part of #1107 · stacked on #1121 (base switches to
mainonce #1121 merges)Before: Bind app listed apps already bound to the same Bot, greyed out as "already bound to this Bot", although External identities already shows them.
After: Bind app leaves this Bot's own apps out. Apps another Bot uses stay greyed out with that Bot's name.
How
ExternalIdentityListfilters accounts that match one of this Bot's identities before building the Bind app options; the "already bound to this Bot" hint and its locale key are gone.Screenshots
Real Host with a simulated Lark provider; Bind app opened from Bob, whose own app is no longer listed. All variants: https://github.com/BotHarness/BotHarness/tree/claude/1127-hide-own-apps/docs/assets/pr/1127-hide-own-apps
Tests
external-identity-list.test.ts: Bind app lists the free app and another Bot's app (disabled, with owner), not this Bot's own app.pnpm changelog:checkare clean.Human verification
🤖 Generated with Claude Code
https://claude.ai/code/session_01WXjBatxGTRyRSxZYeJpqgH
Generated by Claude Code