Repository navigation
Real group names for Lark, Slack and Discord sources (#1151) - #1160
Merged
Merged
Conversation
…1145) A group Channel can connect a known group of a bound app. Every message is placed in the Channel as a Source Event anchored to the ingest, member Bots get context-only admissions by default, and the ingest's wake setting can switch to digest or every message. Pause and Delete keep history. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
…#1151) Inbound evidence may carry conversation.name; group entries, held entries, connected conversations and placed sources show it and pick up renames with the next message. Repins the development IM provider to the dsh-im build that looks the names up. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (6)
📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
#1151) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
DoodleBears
marked this pull request as ready for review
October 7, 2026 21:41
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
…; glossary wake wording (#1145) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
origin/main's tree equals f2662de, already merged above. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
DoodleBears
changed the base branch from
claude/1145-lark-group-ingest
to
main
October 8, 2026 05:27
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1151 · Parent #1144 · Stacked on #1148 (will retarget to main once it merges)
Before: a group from Lark, Slack or Discord showed up everywhere as its ID: in External identities, in a connected external conversation, on the message in the Channel, and in what the Bot read. Lark sender names often fell back to the open_id, because the 1.5 s lookup timed out.
After: the real group name is shown. Discord reads as
Server #channel. The Bot sees the name, and the ID stays next to it in the context. Existing entries pick up the name with their next message. A failed lookup falls back to the ID and never blocks the message.How
claude/1151-real-names, pinned at a0ba283, on top of the previous pin):im.v1.chat.getin parallel with the sender name. Both are cached per app (names 1 h, misses 1 min), and the timeout is 3 s.conversations.inforesult it already checks.lib/is rebuilt, since that bundle is what DSH actually loads.MessagingInboundEvent.conversation.nameis optional, and the dsh-im schema accepts it.conversationName()uses it for groups.Real-IM E2E (cloud QA Host, 2026-10-07/08)
Vain sent real messages in the Lark group "BH Cloud QA", in Slack #bh-cloud-qa and in Discord "DeepSeekBot Cloud QA" #常规. Every source arrived with its name:
BH Cloud QA,bh-cloud-qaandDeepSeekBot Cloud QA #常规. The Lark sender showed as MUFENG YANG instead of the open_id. The existing entries for all three platforms and the connected Lark conversation were renamed by the next message. Lark, Slack and Discord each got a reply.One gap came up during E2E. A Lark @mention that went through the grant path still recorded the ID as its Channel origin. 19e0122 fixes this. On 2026-10-08, two new Lark @mentions showed
Lark/Feishu BH Cloud QA(second screenshot).🤖 Generated with Claude Code
https://claude.ai/code/session_01TukXcCoCAFsqkoHCthVEKC