Repository navigation
feat: prepare checked Lark parent videos in Channel bubbles - #1950
Merged
Merged
Conversation
Issue: #1023 Agent-Task: codex/local/01a13902-0d72-7872-ac0f-440e152155d5
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Issue: #1023 Agent-Task: codex/local/01a13902-0d72-7872-ac0f-440e152155d5
This was referenced Oct 15, 2026
Merged
Issue: #1023 Agent-Task: codex/local/01a13902-0d72-7872-ac0f-440e152155d5
Keep bridged video attachments alongside cleared media and QQ direct messages, and pin the synced Provider. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Media authority only knew bridge routes, so a Channel connected with channel-connect could not reach any source media. Record native video qualification. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
DoodleBears
marked this pull request as ready for review
November 2, 2026 18:53
This was referenced Nov 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1023 · Task claim · Provider dsh-im#31 · Agent-Task:
codex/local/01a13902-0d72-7872-ac0f-440e152155d5Why the change
Show a checked Lark parent video in its existing Channel request bubble so a Human can explicitly prepare and manually play the original without changing Bot attention or source authority.
Special things to note
Change outline
The player reuses DSH primitives, existing file download and video layout. Preparation is explicit and shares the three-request/25 MiB/30-second bounds. No autoplay, runtime transcoding, generated cover or model transcript is introduced. Missing, refused or undecodable cover does not block video; unsupported video format and transfer/source failures remain visible with original download available. Unmount and authority changes cancel acquisition and revoke URLs. Mobile accepts the wire shape as an original-file action and suppresses eager cover preview. The existing Bot Inbox source inspector also excludes the Lark video and cover from its automatic preview loop; it keeps explicit original-download actions, and the related 23-test Inbox/video run passed, including unchanged WeChat behavior. Final-head full verification passed for
5e9f2a9f067aea06f629bfa1c72bbabd178e338d: all three test shards, lint/format/typecheck/build, docs and isolated DSH smoke succeeded. Real-model scenarios are skipped. npm candidate preparation also passed; it is not publication or native media acceptance.Visual and native qualification blocker
The Human supplied two genuine native videos through the Lark client. The latest parent was quoted with a real Bot mention through the built-in browser. The candidate retained the canonical Source Event with the exact native parent, 6000 ms duration, video/unknown primary and image/unknown native cover; IDs were checked against the platform parent. Official DeepSeek Flash DM succeeded. However, the native identity endpoint returned HTTP 429 / 99991403, "This month's API call quota has been exceeded" (token authentication still returned 200/code 0). The result Outbox failed provider-unavailable with zero send attempts and no receipt. Managed-file and Attachment-binding counts stayed zero. No playback, download or installed-product media success is claimed. The exact task-owned receiver was unbound and stopped; QA2 is released. The remaining native gates require restoration of the Lark API quota.
An additional isolated source-Provider installation preflight verified the exact
f889a5808a342bb9b4abf586f115e57cb44b2b6bruntime: 421 files, SHA-25602a4b38aaca218091e52bfa8a8b91be4c98f5d41458356ca9ecd0ee928633819, DSH 0.2.0-rc.2, authenticated API healthy, zero configured Lark Apps. Only that task-owned empty Host was stopped afterward. This verifies source installation and registration, not a fresh product-artifact/native media E2E.Runnable review path after browser reconnection: verify the Human account and QA2 group, prepare an exclusive cutoff guard, upload one uniquely marked native video via Image & video, quote it with a genuine Bot mention, and correlate Source/Admission/Outbox facts. Open its Inbox source inspector before preparing the Channel player and verify zero video/cover acquisition; test its explicit original download separately. Compare original hashes, then test manual decoded playback, cover, refresh/restart and stop/unbind lifecycle. Capture the same source and viewport in light/dark before/after and record the interaction. The checkpoint keeps these gates open. A private HTML explainer binds Core head
5e9f2a9f067aea06f629bfa1c72bbabd178e338dand Provider headf889a5808a342bb9b4abf586f115e57cb44b2b6b; its complete content was scanned and desktop/narrow layouts inspected through a headless browser. It is not hosted or reviewer-accessible evidence.