Repository navigation
fix(mobile): Android Back uses the Material arrow - #2358
Merged
Merged
Conversation
…ttons Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJ8gcMTgoRjSRBNFswZT9T
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJ8gcMTgoRjSRBNFswZT9T
…-m7tsnr-appbar # Conflicts: # apps/mobile/DESIGN.md # apps/mobile/src/ui/primitives/sheet-stack.tsx
Captured on a Xiaomi phone (Android 16, HyperOS 3, arm64, gesture navigation, zh-CN) running an arm64 debug dev client of main 48f35fb with this branch's JavaScript, in light, dark and font scale 2.0. Chat top bar with the Material back arrow and tonal buttons, and a drawer subpage back arrow. Status bar and computer names are redacted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJ8gcMTgoRjSRBNFswZT9T
Retaken on the Xiaomi phone (Android 16, HyperOS 3, zh-CN) with this branch's latest JavaScript (27e17cd) on an arm64 debug dev client of main 4c02815, in light, dark and font scale 2.0. Replaces chat-appbar-{light,dark,font}.png only. Status bar redacted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
DoodleBears
marked this pull request as ready for review
October 20, 2026 08:35
Retaken on the Xiaomi phone (Android 16, HyperOS 3, zh-CN) with this branch's latest JavaScript (0c68476) on an arm64 debug dev client of main d32694a, in light, dark and font scale 2.0. Replaces chat-appbar-{light,dark,font}.png only. Status bar and computer names redacted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Keep main's floating Android header fill (#2394); this PR now only swaps Back to the Material arrow. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QbudM552v4qrLMzopz7j7k
DoodleBears
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Why the change
On Android, Back in the chat header and in drawer and sheet headers drew the iOS chevron instead of the Material
arrow_back.Refs: M3 app bars, #2339, #2338.
Special things to note
headerGlassFill, frostedraisedwith a hairline), and that was QA'd on the phone. The filled tonal header buttons from this PR would have replaced that look, so they were dropped. This PR now only swaps the Back icon.DESIGN.mdand the change fragment say the same.tsc --noEmit,oxfmt --checkandvitest apps/mobile(134 files passed, 7 skipped) after merging main. The newback-icon-android.test.tsxchecks the Android arrow and the iOS chevron.Change outline
BackIcon(shell/back-icon.tsx/.android.tsx): a chevron on iOS, Materialarrow_backon Android. It is used by the chat header's round Back button and byDrawerHeader, which covers every drawer and sheet header.Screenshots
Physical phone: Xiaomi, Android 16 / HyperOS 3, gesture navigation, Chinese UI. Files are in
.github/pr-screenshots/2358-android-appbar/phone/on this branch (Files changed).chat-appbar-light.pngchat-appbar-dark.pngchat-appbar-font.pngdrawer-subpage-light.pngdrawer-subpage-dark.pngdrawer-subpage-font.pngThe chat app bar shots predate #2394's floating header, so they show an opaque bar; on main the arrow sits in #2394's round frosted Back button. The drawer subpage shots are current. A fresh chat-header shot is queued with the next phone run.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QbudM552v4qrLMzopz7j7k