Repository navigation
fix(mobile): show which folder the picker will authorize - #2421
Merged
Merged
Conversation
After backing out of a registered folder's confirm sheet, the primary button still authorized the folder being browsed (its parent) with no visible target, and Android QA granted the parent by mistake. Both folder sheets now show "Will authorize: <path>" above the actions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GzQmtMAahcsx9doCNJgFLe
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GzQmtMAahcsx9doCNJgFLe
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DoodleBears
added a commit
that referenced
this pull request
Oct 20, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Android phone result: PASS (Xiaomi, Android 16 / HyperOS 3, isolated QA Host and release build of main with this PR) Screenshots: 2421-android-folders/phone (commit e9c856d)
Each theme granted only a newly created empty test folder; the path was correct both times. Both grants were revoked and the folder deleted. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Why the change
Android QA of #2392 (comment) tapped a registered folder, pressed Back on its confirm sheet, then pressed Authorize this folder. That button grants the folder being browsed (the parent,
D:\code), but nothing on screen said so, and the parent was granted by mistake (revoked within a minute, nothing changed).Issue / Discussion: Refs #2392.
Special things to note
Will authorize: <full path>/将授权：<完整路径>above the actions. I first tried putting the folder name on the button, but a long name pushed Cancel off screen, so the path sits on its own wrapping line and the button label stays short.apps/mobile/test/grant-request-card.test.tstaps the registered row, goes Back, and asserts the sheet names/Users/qa, not the registered path; mobilegrant-request-cardandbot-settingstests pass, andpnpm lint,pnpm format:checkand the mobile typecheck pass.node scripts/e2e-mobile-folder-browse-web.mjspassed with a realdeepseek-v4.1-flashrequest and a newnamesTargetcheck. Native Android recheck is queued with the Android thread after merge.Change outline
Expo Web export at 390×844; layout evidence, not native.
Generated by Claude Code