Repository navigation
fix(mobile): cap header glass button symbols at xxxLarge Dynamic Type - #2502
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012p4JA6z94Erp3Jy4JciiuD
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Why the change
QA on the iOS 27 Simulator found a problem with the glass buttons from #2487 at AX5. The SF Symbols in the Chats and Activity header buttons grow with Dynamic Type, but the 44pt glass circle stays the same size, so the glyphs spill out of it.
Issue / Discussion: follow-up to #2487.
Special things to note
dynamicTypeSize({ max: 'xxxLarge' }), on the symbol inHeaderActionon iOS 26+. System toolbar symbols behave the same way: they stop growing at accessibility sizes, and the accessibility label is still there. Nothing changes for iOS < 26 or Android.vitesttest/header-action.test.tsx,tsc --noEmitandpnpm lintall pass. Not yet run: an AX5 re-check on the iOS 27 Simulator. Following Vain's merge-first rule, it will run in the next combined batch on main.changes/fragment: this fixes the unreleased feat(mobile): native Chats and Activity header buttons (Liquid Glass on iOS 26, Material 3 on Android) #2487 entry, which still describes the behaviour correctly.Change outline
header-action.ios.tsx: addsdynamicTypeSize({ max: 'xxxLarge' })to theImage.Generated by Claude Code