Skip to content

fix(mobile): cap header glass button symbols at xxxLarge Dynamic Type - #2502

Merged
DoodleBears merged 1 commit into
mainfrom
claude/project-thread-cvodvl
Oct 21, 2026
Merged

DoodleBears merged 1 commit into
mainfrom
claude/project-thread-cvodvl

Conversation

@DoodleBears

Copy link
Copy Markdown
Contributor

Requested by Vain · project thread

Why the change

QA on the iOS 27 Simulator found a problem with the glass buttons from #2487 at AX5. The SF Symbols in the Chats and Activity header buttons grow with Dynamic Type, but the 44pt glass circle stays the same size, so the glyphs spill out of it.

Issue / Discussion: follow-up to #2487.

Special things to note

  • Merge risk: very low. This adds one SwiftUI modifier, dynamicTypeSize({ max: 'xxxLarge' }), on the symbol in HeaderAction on iOS 26+. System toolbar symbols behave the same way: they stop growing at accessibility sizes, and the accessibility label is still there. Nothing changes for iOS < 26 or Android.
  • Verification: vitest test/header-action.test.tsx, tsc --noEmit and pnpm lint all pass. Not yet run: an AX5 re-check on the iOS 27 Simulator. Following Vain's merge-first rule, it will run in the next combined batch on main.
  • No changes/ fragment: this fixes the unreleased feat(mobile): native Chats and Activity header buttons (Liquid Glass on iOS 26, Material 3 on Android) #2487 entry, which still describes the behaviour correctly.
  • CI test plan: affected (mobile only).

Change outline

  • header-action.ios.tsx: adds dynamicTypeSize({ max: 'xxxLarge' }) to the Image.
  • DESIGN.md: one sentence on the cap.

Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012p4JA6z94Erp3Jy4JciiuD
@DoodleBears DoodleBears self-assigned this Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bc15367a-f60c-46d9-8c3b-116c309ea8c0
📥 Commits

Reviewing files that changed from the base of the PR and between 4227b25 and d6d3db0.

📒 Files selected for processing: 3
  • apps/mobile/DESIGN.md
  • apps/mobile/src/ui/shell/header-action.ios.tsx
  • apps/mobile/test/header-action.test.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DoodleBears
DoodleBears merged commit 77ddca9 into main Oct 21, 2026
10 checks passed
@DoodleBears
DoodleBears deleted the claude/project-thread-cvodvl branch October 28, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants