Repository navigation
feat(client): show remote Bot and group avatars - #2535
Conversation
|
Exact-head review aid refreshed for 0364c52, against base b1cf50e (2026-10-21 UTC). The five-panel HTML explains the registry commit → Host Feed → authenticated object-URL cache → shared All 12 embedded GitHub images loaded at 1440×900, with positive rendered bounds; the longest URL is 113 characters. The body was read back with its attribution, real Task ID and correct Track 1 claim. Validation is split by SHA: before the final rebase, full build/typecheck/lint/format and 13 files /171 tests passed. Current exact head passed the single-worker boundary regression: 6 files /50 tests, covering StyleX, remote avatars, gateway, pairing, Connect account and paired-device UI. Main's final rebase added pairing receipt/status, explicit revoke results and Connect account lifecycle/UI changes. Final-head full build belongs to new CI with unchanged gates. Real two-Host update/clear/restore/remove passed twice, including canonical image pixels, blob revocation and saved-device removal. Both driven pages reported ready with zero console/image errors. The first run's separate historical resource-load failures remain unexplained and retained, not classified as a baseline or revoked-blob probe. Later captured failures were retried diagnostic-fetch aborts. Runtime captures exercise avatar implementation 87b4cad before the subsequent common generator integration. Only verified task Hosts 47111/47112 were stopped; profiles and old evidence remain. No further model invocation occurred; the earlier real reply used deepseek-v4-pro. DSH Desktop, native-phone QA and physical-machine tailnet remain unqualified. Human QA, CI review and merging stay with the coordinator. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue: #2500 Agent-Task: codex/local/01a15ee9-772a-7060-893b-027cecd4242d
Issue: #2500 Agent-Task: codex/local/01a15ee9-772a-7060-893b-027cecd4242d
Issue: #2500 Agent-Task: codex/local/01a15ee9-772a-7060-893b-027cecd4242d
Issue: #2500 Agent-Task: codex/local/01a15ee9-772a-7060-893b-027cecd4242d
StyleX commonJS hashes package-relative paths with native separators. Normalize the custom resolver's package identity to forward slashes while preserving extension fallback. Windows output now matches the Linux CI Browser and Computer bundles byte for byte. Issue: #2500 Agent-Task: codex/local/01a15ee9-7784-7292-9194-6a6b18b23098
Issue: #2500 Agent-Task: codex/local/01a15ee9-772a-7060-893b-027cecd4242d
87b4cad to
0364c52
Compare
Requested by Vain. Refs #2500 · Track 1 claim · Task:
codex/local/01a15ee9-772a-7060-893b-027cecd4242d.Why the change
远程频道列表、会话标题和 Bot 作者现在使用所属 Host 的真实头像，并在头像保存后通过现有 Host Feed 刷新。
Special things to note
previewskips local Tob lookup, group data URLs remain direct, and registry notifications occur after committed avatar edits. The Desktop: icon-only Host strip, Add remote in the + menu; ADR-0243 drops environment tabs #2508 icon-only Host strip stays intact;remote-hosts.tsis unchanged. Required Browser/Computer bundles were rebuilt and committed; their maps remained byte-identical.pnpm build(process-localGOMAXPROCS=2),pnpm typecheck,pnpm lint,pnpm format:check, and 13 files / 171 focused tests. The first unbounded-thread build was stopped and its log retained. On current head 0364c52, a single-worker boundary regression passed 6 files / 50 tests: StyleX, remote avatars, Device gateway, pairing, Connect account, and paired-device UI. The final rebase to b1cf50e adds main’s Connect/pairing work; the complete checks are not claimed as rerun across that SHA. New CI retains the original gates and owns final-head full build verification. Earlier independent suspected-baseline suites passed 11 tests, docs tests passed 4, and docs build passed; these remain earlier-stage evidence. Real local two-Host QA usesdeepseek-v4-pro; light/dark before/after screenshots cover uploaded/seeded Bots, group member stacks, custom group images, headers and persisted authors. Dynamic QA: update, clear, restore and Remove Host passed on two real isolated Hosts, with canonical pixel checks, blob revocation, ready-shell observations and zero console/image errors. The first resumed run also recorded separate failed observer attempts whose resource URLs were not captured; their cause remains unresolved, with evidence retained. Later instrumented runs only recorded retried diagnostic-fetch aborts, not image failures. The shared StyleX portability fix was integrated independently from Track 2; new CI remains authoritative. Human QA remains with the coordinator. Remote bodies still show text/attachment names only; images/cards/approvals belong to Track 5. Host looks are intentionally device-local. DSH Desktop, native phone QA and physical-machine tailnet QA are unqualified; the live streaming-draft avatar path was not directly observed.affectedvia existing source/test/reference rules; no rule addition. Broader local selections were bounded and stopped without a completion report; exact focused results and baseline failures are stated above. Parent orchestrates review and merging; this PR does not close Web: pair a second Computer and switch the channel list between All and each Computer #2500.Change outline
RemoteAvatar({ roster, avatars, target, size, t })is reusable by Track 5; it performs no network request or subscription.GroupAvatarBotnarrows the existing component contract. Device gateway production code is unchanged; its regression test covers the real avatar GET/query, PNG bytes, CORS and missing/revoked/cookie/origin rejection.Light, before → after:
Dark theme, group member stack and custom group image — matched before/after
Dynamic two-Host QA: update → clear → restore → remove Host
The same open page follows the committed avatar through Host Feed updates; row, header and authors change together. Canonical image pixels, old blob revocation, and removal from saved devices were checked. Both instrumented runs reported a ready shell and zero console/image errors. The first resumed run's separate historical resource-error attempts remain unexplained and retained; this is not classified as a known baseline.