Repository navigation
feat(client): add Remote Host Browser and Computer viewers #2539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
590667d
feat(client): open Remote Host Browser and Computer viewers
DoodleBears 5a89841
fix(client): order viewer input and avoid companion overlap
DoodleBears 2a4f0d3
fix(client): invalidate viewer control and release before unpair
DoodleBears ae31bf1
fix(client): recover static viewer frames and localize errors
DoodleBears 79bacaf
fix(client): keep viewer reconnect visible in workspace
DoodleBears 6f64651
test(client): capture visible reconnect and read-only recovery
DoodleBears File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| section: Added | ||
| --- | ||
|
|
||
| ## en | ||
|
|
||
| - Open a Remote Host Bot's Browser or Computer viewer from its conversation, pause the Bot to send input, and release control when the viewer closes. Resuming the Bot or losing frames discards queued input; recovered frames require another explicit takeover. Shared viewers recover unchanged screens after a connection failure, and Web errors offer localized recovery guidance. Removing a Host waits up to five seconds for viewer cleanup before revoking the pairing. The viewers reuse the paired-device frame and input routes ([#2500](https://github.com/BotHarness/DeepSeekBot/issues/2500)). | ||
|
|
||
| ## zh | ||
|
|
||
| - 可从远程 Bot 对话打开浏览器或共享桌面画面,暂停 Bot 后操作,关闭画面时交还控制权。恢复 Bot 或画面失联会丢弃排队输入;画面恢复后须重新明确接管。共享查看器可在连接故障后恢复未变化的画面,网页错误提示提供本地化恢复建议。移除 Host 时先等待画面释放控制,最多五秒,再撤销配对。画面与输入复用已配对设备的接口([#2500](https://github.com/BotHarness/DeepSeekBot/issues/2500))。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
The
remoteViewer.noAccesstext names the Browser, but the Computer viewer also uses it.RemoteHostViewerPanelshows this string forstatus === 'no-access'for bothbrowserandcomputerkinds. A Computer viewer user sees "This Bot has no Browser access." or "此 Bot 没有浏览器权限。". The text misdirects the user.Make the text kind-neutral:
Proposed fix
As per coding guidelines: "keep hints, captions and errors short and plain in both English and Chinese."
Also applies to: 4179-4179
🤖 Prompt for AI Agents
Source: Coding guidelines