Repository navigation
fix(mobile): use full conversation rows in Pinned - #2618
Merged
Merged
Conversation
Issue: #2571 Agent-Task: codex/local/01a16587-3995-7b22-8c81-7c19caccddef
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 13
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2571 | Design-feedback follow-up to #2574 | Agent claim
Task:
codex/local/01a16587-3995-7b22-8c81-7c19caccddefWhy the change
Human screenshot feedback found the mobile Pinned grid hard to scan, so Pinned now uses the same conversation rows as other sections to make names, message previews, timestamps and unread/status information easier to read.
Special things to note
Change outline
Pinned rows reuse ordinary swipe actions, iOS preview/context menu, Android long-press and accessibility actions. Removed the card, width/column policy and band projection. Kept coverage for 100 individually virtualized pins, order and collapse; updated design, the unreleased bilingual fragment and the native verification journey to the accepted list presentation.
Batch63 native evidence — iPhone 17 Pro Simulator, iOS 27 beta, 402 × 874 pt
Before
5be050bef4dcruns the grid; After76078cfc7fc5runs this merged list change. Same installed Debug dev client, verified iOS fingerprint4176fdf936e537bf2a1b7f6f5d906e2ca1615ecc, with independently verified loaded JS for each revision. The synthetic “QA Batch 62” connection is the retained fixture reused by Batch63, not the old product revision. The six pairs match data, locale, device, theme and system text size; both DM rows have one unread message before any interaction tests.Light · default system text — Before grid / After list
Light · intermediate system text — Before grid / After list
Light · maximum system text — Before grid / After list
Dark · default system text — Before grid / After list
Dark · intermediate system text — Before grid / After list
Dark · maximum system text — Before grid / After list
At maximum text size, names are heavily ellipsized and the workspace header becomes tall; the tall header is also present in the matched baseline. Scrolling and opening the final row passed, but this is not a blanket readability or accessibility acceptance.
Actual interaction checks
Swipe actions
Unpin returns to Work
Native preview and context menu
Native section picker
Search with real native keyboard
Search closed; collapse restored
27 pinned rows, newest first
End of 27 pinned rows
Maximum text: final loose row reachable
Maximum text: final row opened
Not tested: Android, physical/Release app, VoiceOver/TalkBack, wide/rotation layouts, working-state transitions, an independent Mark read command, two disposable Hosts/Cloud/Web scope isolation and failure/reconnect behavior. Peek/open changed unread state; this does not prove a separate Mark read action. Prior provider quota errors mean no live model-working claim. Human design acceptance remains separate.
Public screenshot provenance and limitations. All 22 images were visually inspected and contain only synthetic QA data. Temporary 24 empty groups removed; original pins/section membership restored. This batch's Host, both Metro servers and driver stopped with ports released; original Simulator workspace/theme/text restored. Retained phone services and shared package outputs were preserved. No phone install, release or deployment.