Repository navigation
test(cli): keep the closed-stdout test working on Python 3.14 - #94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test added in #54 fakes a stdout whose fileno() always raises ValueError. On Python 3.14, argparse calls sys.stdout.fileno() while the parser is built, so main() failed before it reached the code under test and the ubuntu/macOS 3.14 jobs on main went red.
The fake now raises the ValueError only after the write has failed, which is the case the test is meant to cover. Verified on 3.13 and 3.14: 617 passed, 100% line and branch coverage, ruff clean. Removing ValueError from the except in _silence_broken_pipe makes the test fail on both versions.
Tests only, no CHANGELOG entry needed.