Skip to content

5422 changes - #103

Open
praveenkumarsamala wants to merge 1 commit into
CAAPIM:mainfrom
praveenkumarsamala:5422-changes
Open

5422 changes#103
praveenkumarsamala wants to merge 1 commit into
CAAPIM:mainfrom
praveenkumarsamala:5422-changes

Conversation

@praveenkumarsamala

Copy link
Copy Markdown

No description provided.

@Gazza7205

Copy link
Copy Markdown
Contributor

Please use a branch to make these changes and consider creating a PR against develop/portal

@praveenkumarsamala

Copy link
Copy Markdown
Author

Please use a branch to make these changes and consider creating a PR against develop/portal

Sure, i will change it.

serviceAccountName: portal-g2c-agent
hostAliases:
- ip: "10.96.228.133"
- ip: "10.252.128.127"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not change this line

Comment thread example/Makefile

install:
kubectl apply -f https://github.com/CAAPIM/layer7-operator/releases/download/v1.3.0/bundle.yaml
kubectl apply -f https://github.com/CAAPIM/layer7-operator/releases/download/v1.2.2/bundle.yaml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 1.3.x

Comment thread example/Makefile
--cert=/tmp/otk-dmz-mtls.crt --key=/tmp/otk-dmz-mtls.key \
-n $(NAMESPACE) --dry-run=client -o yaml | kubectl apply -f -
-kubectl create configmap otk-internal-ca-cert \
-kubectl create secret generic otk-internal-ca-cert \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have u tested these changes? If not lets not add these lines

Comment thread example/Makefile
-kubectl delete ns observability
-kubectl delete ns monitoring
-kubectl delete -f https://github.com/CAAPIM/layer7-operator/releases/download/v1.3.0/bundle.yaml
-kubectl delete -f https://github.com/CAAPIM/layer7-operator/releases/download/v1.2.2/bundle.yaml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 1.3.x

@ksaladi ksaladi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added few comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants