fix(cli): treat MCP tool isError as a failed mcp call - #128
Open
Arshgill01 wants to merge 1 commit into
Open
Conversation
Generic `calle mcp call` reported ok:true and exited 0 when the tool result had isError:true. Use the same CallStageError path as dedicated call commands so shell automation cannot take the success branch. Closes CALLE-AI#127 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calle mcp calltreated any HTTP 200 MCP tool result as success, includingisError: true, so it printedok: trueand exited 0.calle call *already throwsCallStageErrorin that case.mcp callnow uses the same check and safe remote-error fields.Fixes #127.
Test plan
pnpm --filter @call-e/cli test:unit— 61 pass, includingmcp call treats tool isError as a failed commandmcp callsuccess tests still exit 0pnpm --filter @call-e/cli checkpnpm --filter @call-e/cli pack:dry-runresult.isError: trueshould now matchcalle call status(ok: false, exit 1) and must not print extra structured secretsMade with Cursor