Skip to content

Read pending messages from rx fifo - #127

Open
anmelle-slamcore wants to merge 1 commit into
CANopenNode:masterfrom
anmelle-slamcore:read-all-pending-rx-fifo
Open

Read pending messages from rx fifo#127
anmelle-slamcore wants to merge 1 commit into
CANopenNode:masterfrom
anmelle-slamcore:read-all-pending-rx-fifo

Conversation

@anmelle-slamcore

Copy link
Copy Markdown

Proposed fix for issue #126

@MaJerle

MaJerle commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Since you have added the while loop in the block, this code needs indent process as it now misses it.
As explained previously, please use the clang-format tool to format the code with the .clang-format file in this repository.

@anmelle-slamcore

Copy link
Copy Markdown
Author

Since you have added the while loop in the block, this code needs indent process as it now misses it. As explained previously, please use the clang-format tool to format the code with the .clang-format file in this repository.

Maybe I am doing something wrong, but git clang-format does not modify any file on this staged change

@MaJerle

MaJerle commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

I found a bug in the clang-format and now I have uploaded a new one:
#131

Please reformat the code and recommit, then we merge.

Sorry for this.

@anmelle-slamcore

Copy link
Copy Markdown
Author

I found a bug in the clang-format and now I have uploaded a new one: #131

Please reformat the code and recommit, then we merge.

Sorry for this.

Done. Please have a look at the final result, since there was a merge conflict I had to resolve from recent #125 MaJerle/fix-fdcan-array-length merge.

@HamedJafarzadeh HamedJafarzadeh self-assigned this Sep 9, 2026
@MaJerle

MaJerle commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Looks OK to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants