Skip to content

Add explicit weights_file configuration option. - #99

Merged
JordanLaserGit merged 4 commits into
mainfrom
issue-45-weights-file
Aug 20, 2026
Merged

JordanLaserGit merged 4 commits into
mainfrom
issue-45-weights-file

Conversation

@toakinrele

Copy link
Copy Markdown
Collaborator

Adds support for an explicit weights_file configuration option so precomputed weights can be supplied independently of gpkg_file.

Changes:

  • weights_file takes precedence when provided.
  • Existing gpkg_file behavior remains as the fallback.
  • gpkg_file is still used for hydrofabric-dependent operations such as plotting.
  • Consolidated plotting validation logic.
  • Added a test for the weights_file override functionality.

Testing:

  • test_weights_file_override passes locally.
  • test_plotting passes locally.
  • CSV, Parquet, and NetCDF output tests pass individually.

Closes #45.

@toakinrele
toakinrele requested review from JordanLaserGit and quinnylee and removed request for JordanLaserGit August 11, 2026 15:05

@JordanLaserGit JordanLaserGit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @toakinrele! Thanks for this work. We can ignore both failing tests in the pr as one has been documented here #101 and the other here #103.

@JordanLaserGit
JordanLaserGit merged commit 41ba4b8 into main Aug 20, 2026
71 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make weight file hack an explicit option

3 participants