[spjuhel]

Changes proposed in this PR:

• Remove the broken WORLD_BANK_WEALTH_ACC URL constant and FILE_WORLD_BANK_WEALTH_ACC filename constant
• Rewrite world_bank_wealth_account to fetch data via download_world_bank_indicator instead of downloading and unzipping a CSV file; interpolation/extrapolation logic and the no_land correction are unchanged
• Remove now-unused imports: zipfile, Path
• Update docstring year range for world_bank_wealth_account from 1995–2014 to 1995–2020 to reflect the current dataset coverage
• Update docstring and documentation to reflect change to 2019 real chained USD (from constant 2014)
• Update test values to reflect changes

This PR fixes #1291 and #1293

PR Author Checklist

• Read the Contribution Guide
• Correct target branch selected (if unsure, select develop)
• Descriptive pull request title added
• Source branch up-to-date with target branch
• Documentation updated
• Tests updated
• Tests passing
• No new linter issues
• Changelog updated

PR Reviewer Checklist

• Read the Contribution Guide
• CLIMADA Reviewer Checklist passed
• Tests passing
• No new linter issues

[spjuhel]

@emanuel-schmid or @peanutfun, this should be a quick one to review. And will fix some of the currently failing tests.

[carmensteinmann]

There are some administrative regions, which lead to an error when trying to create LitPop for them.
I started from an old, global LitPop object and wanted to create a new LitPop object for all region ids. The failing admin units are: ['ALA', 'ESH', 'HMD', 'PCN', 'SGS', 'UMI']
These are: Åland Islands, Western Sahara, Heard Island and McDonald Islands, Pitcairn Islands, South Georgia and the South Sandwich Islands, United States Minor Outlying Islands

Please find the code how to determine these below.

country_names = global_litpop.gdf.region_id.unique()
iso3a_list = u_coord.country_to_iso(country_names, representation="alpha3")

info_ind = "NY.GDP.MKTP.CD"
data = []
network = []

for cntry_iso in iso3a_list:
    try:
        cntry_gdp = util_fin.download_world_bank_indicator(indicator=info_ind, country_code=cntry_iso, parse_dates=False)
    except (ReadTimeout, RequestException):
        print(f"Network issue: {cntry_iso}")
        network.append(cntry_iso)
    except ValueError as e:
        print(f"Data/API issue for {cntry_iso}: {e}")
        data.append(cntry_iso)

failing_c = []
for country in data: 
    print(country)
    try:
        exp = LitPop.from_countries(country, reference_year=2002)
    except ValueError as e: 
        failing_c.append(country)

[emanuel-schmid]

Looks good to me. In any case an improvement! 🥇
Happy to merge.

[emanuel-schmid]

is this url correct? wasn't it meant to be replaced?

[spjuhel]

No this one is still good.

The ones outdated were those (notably the ones pointing to files):

WORLD_BANK_WEALTH_ACC = (
    "https://databank.worldbank.org/data/download/Wealth-Accounts_CSV.zip"
)
"""Wealth historical data (1995, 2000, 2005, 2010, 2014) from World Bank (ZIP).
    https://datacatalog.worldbank.org/dataset/wealth-accounting
    Includes variable Produced Capital (NW.PCA.TO)"""

FILE_WORLD_BANK_WEALTH_ACC = "Wealth-AccountsData.csv"

WORLD_BANK_INC_GRP = (
    "http://databank.worldbank.org/data/download/site-content/OGHIST.xls"
)

[emanuel-schmid]

... failing admin units are: ['ALA', 'ESH', 'HMD', 'PCN', 'SGS', 'UMI']

@carmensteinmann you are right, these country codes are not listed as worldbanks indicators. it's a problem, but not related to this PR. See #1331