[spjuhel]

This PR fixes a bug in calc_eai_gdf (both for static and interpolated trajectories) where the exposure points coordinates are incorrectly mapped to the corresponding risk value when the exposure GeoDataFrame index is discontinuous.

The suggested fix directly uses the index, instead of creating it from a range.

PR Author Checklist

• Read the Contribution Guide
• Correct target branch selected (if unsure, select develop)
• Descriptive pull request title added
• Source branch up-to-date with target branch
• Documentation updated
• Tests updated
• Tests passing
• No new linter issues
• Changelog updated

PR Reviewer Checklist

• Read the Contribution Guide
• CLIMADA Reviewer Checklist passed
• Tests passing
• No new linter issues

[peanutfun]

Looks reasonable. But are there no tests for the results?

[spjuhel]

There are, just not for the very specific case where the index of the geodataframe of the exposure is not a continuous range of number.

[peanutfun]

Is that a hassle to implement? Simply dropping a row from a built exposure object before the test should do it, right?

[chahank]

Does this need a test to avoid breaking it in the future?

[emanuel-schmid]

looks nice - but sorry, I don't get it. 😕 A test would be awesome. But also a more explanatory description could help.

[emanuel-schmid]

Does this need a test to avoid breaking it in the future?

I think it's less about the future and more about the change: show the bug and the prove that it's fixed.

[spjuhel]

I've added a specific non range based index in the exposure factory.

With it and without the fix, two existing tests related to the computation of EAI fail.
The test run fine with the fix.

I would assume that's enough?

[emanuel-schmid]

🙌