Repository navigation
fix: dead negative-frequency check, message typos, stray prints - #1338
Open
EnvDroneSense wants to merge 4 commits into
Open
EnvDroneSense wants to merge 4 commits into
EnvDroneSense wants to merge 4 commits into
Conversation
EnvDroneSense
requested review from
chahank,
emanuel-schmid and
peanutfun
as code owners
October 22, 2026 21:38
spjuhel
reviewed
Oct 23, 2026
spjuhel
reviewed
Oct 23, 2026
spjuhel
approved these changes
Oct 23, 2026
spjuhel
left a comment
spjuhel
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for these fixes 🙏
I'd say in the future avoid putting two many different fix types in the same PR (e.g. the typos and the stray prints could have been separated from the dead check).
This is good to merge for me @emanuel-schmid, @peanutfun, @chahank
Co-authored-by: Samuel Juhel <10011382+spjuhel@users.noreply.github.com>
Co-authored-by: Samuel Juhel <10011382+spjuhel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
apply_climate_scenario_knu:any(tc_cc.frequency) < 0compared a bool with 0 and never triggered. It is nownp.any(tc_cc.frequency < 0), so negative frequencies raise the intendedValueError. Test added. Results on IBTrACS 1980-2020 do not change (80 scenario combinations, none negative).fprefixes (litpop.py,storm_europe.py).printcalls (calibration_opt.py,impact_data.py).This PR fixes part of #317 (the negative-frequency check).
PR Author Checklist
develop)PR Reviewer Checklist