Repository navigation
[Angular 21] Migrate angular2-hn from Angular 9 to Angular 21 (integrated, 5 parallel feature PRs) - #954
[Angular 21] Migrate angular2-hn from Angular 9 to Angular 21 (integrated, 5 parallel feature PRs)#954devin-ai-integration[bot] wants to merge 13 commits into
Conversation
…t) with placeholder routes per feature Co-Authored-By: danial.asaria <danialasaria@gmail.com>
Co-Authored-By: danial.asaria <danialasaria@gmail.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
| const options = story.poll.map((_, i) => this.fetchPollContent(story.id + i + 1)); | ||
| return forkJoin(options).pipe( | ||
| map((poll) => ({ | ||
| ...story, | ||
| poll, | ||
| poll_votes_count: poll.reduce((sum, option) => sum + option.points, 0), | ||
| })) |
There was a problem hiding this comment.
🔍 Poll option failures now block comments
If one option request fails, forkJoin errors without emitting the poll story or its comments. Previously, fetchItemContent emitted the story independently. No current component calls this service; the change becomes visible when item details returns.
Was this helpful? React with 👍 or 👎 to provide feedback.
Standalone components with inject(), signal-based SettingsService, @if/@for. Markup, CSS classes, styles and text kept identical to the Angular 9 app. Adds Vitest specs for header, footer and settings. Co-Authored-By: danial.asaria <danialasaria@gmail.com>
…input, rxResource, @if) Co-Authored-By: danial.asaria <danialasaria@gmail.com>
Co-Authored-By: danial.asaria <danialasaria@gmail.com>
… Angular 21 Standalone ItemDetailsComponent and recursive CommentComponent using signals, input(), inject() and @if/@for, with the Angular 9 markup, CSS classes and text kept as-is. Adds Vitest specs. Co-Authored-By: danial.asaria <danialasaria@gmail.com>
…ceWorker Co-Authored-By: danial.asaria <danialasaria@gmail.com>
…lar21 Co-Authored-By: danial.asaria <danialasaria@gmail.com>
Co-Authored-By: danial.asaria <danialasaria@gmail.com>
…details' into devin/angular21-base
…profile' into devin/angular21-base
Co-Authored-By: danial.asaria <danialasaria@gmail.com>
| http.createServer((req, res) => { | ||
| const urlPath = decodeURIComponent(new URL(req.url, 'http://localhost').pathname); |
There was a problem hiding this comment.
🟨 Malformed URLs terminate the parity server
A request containing /%ZZ makes decodeURIComponent throw outside any exception handler, terminating the parity server. listen(port) exposes this handler on all interfaces, allowing reachable network clients to stop parity runs.
Was this helpful? React with 👍 or 👎 to provide feedback.
| git -C "$REPO_DIR" fetch origin master | ||
| git -C "$REPO_DIR" worktree add --detach "$LEGACY_DIR" origin/master |
There was a problem hiding this comment.
✨ Blast Radius Reviewer: P2 — Legacy parity baseline disappears after merge
After this migration merges into master, serve-legacy.sh checks out Angular 21 as the Angular 9 baseline. Its Node 14 runtime and ng build --prod command cannot build that checkout, so fresh parity runs fail.
View in Devin Review · Custom reviewer
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
Migrates angular2-hn from Angular 9 to Angular 21. This PR started as a shell; five parallel Devin sessions each ported one feature and their PRs are merged into this branch:
Integrated result (this branch):
ng buildOK, Vitest 45/45, Playwright parity suite (parity/) 44/44: same 22 specs green against legacymasteron :4000 and Angular 21 on :4200.Architecture
bootstrapApplication+app.config.ts(provideRouter(routes, withComponentInputBinding()),provideHttpClient(withFetch()),provideServiceWorker); no NgModules.loadComponentroutes:/:feedType/:page,/item/:id,/user/:id.input(),inject(), signals and@if/@for;SettingsServicestate is asignal<Settings>.@angular/build:application, Vitest, strict TS. Removed Karma, Protractor, TSLint,rxjs-compat,unfetch.ng updatechain.Behaviour changes for review
api.hnpwa.com/v0/user/:id.json:node-hnapi/userreturns 404, so profiles are already broken onmaster.200 null) showsCould not load user <id>.instead of legacy's endless loader.index.html.[class.head-margin]="item.text"and a:host >>>block that compiled to a selector matching nothing..nvmrc):npm installcrashes withedgesOuton Node 22's npm 10.Open decisions: delete or port
.travis.yml; add the angular21 parity job to CI; README contributors entry; the jobs header still links to Triplebyte (kept for parity).Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/bf04ab7bce1a434c9014a00a83a9e7dd
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/bf04ab7bce1a434c9014a00a83a9e7dd?variant=devin