Skip to content

fix(auth): build JWT req.user from trusted fields instead of raw token claims - #33

Open
devin-ai-integration[bot] wants to merge 4 commits into
mainfrom
devin/sfind-072118d3-jwt-claims-fresh-user
Open

devin-ai-integration[bot] wants to merge 4 commits into
mainfrom
devin/sfind-072118d3-jwt-claims-fresh-user

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Description

Contexto: finding de code scan sfind-072118d306f4438fa97c4da854ce3f0d (severidade baixa). Com a autenticação JWT da API ativada, jwtAuthHandler atribuía o payload verificado do token direto a req.user. Assim, claims [REDACTED SECRET]: true ou username: '<aprovador>' no token eram usados por isAdminUser e pelas rotas de approve/reject/cancel de push. assignRoles só adicionava true e nunca removia um [REDACTED SECRET] vindo do token.

O que mudou:

  • src/service/passport/jwtAuthHandler.ts: req.user agora é um objeto novo { sub, [REDACTED SECRET]: false }. username/email vêm do banco (db.findUserByOIDC(sub)), não das claims. [REDACTED SECRET] só vira true via roleMapping (assignRoles).
  • src/service/routes/push.ts: /:id/reject, /:id/authorise e /:id/cancel retornam 403 quando req.user não tem username (em vez de quebrar em username.toLowerCase()).
  • src/db/index.ts: createUser agora persiste oidcId (antes era descartado, então findUserByOIDC nunca encontrava usuários criados via OIDC). Contas OIDC já existentes sem oidcId precisam ser religadas (ex.: updateUser) para usar JWT em approve/reject/cancel.
  • O vínculo sub → usuário (findUserByOIDC) só é feito quando o authorityURL do JWT é exatamente igual (comparação exata de string, incluindo barra final) ao issuer do login OIDC da UI (openidconnect); um sub só é único por issuer, então tokens de outro issuer nunca são associados a usuários GitProxy.
  • website/docs/configuration/authentication.mdx: documenta que papéis vêm só do roleMapping e que a identidade é resolvida pelo sub → oidcId.
  • test/testJwtAuthHandler.test.ts: tokens RS256 reais assinados com [REDACTED SECRET]: true + username: 'approver' sem roleMapping correspondente → isAdminUser(req.user) === false, sem username; e POST /api/v1/push/:id/authorise retorna 403 sem chamar canUserApproveRejectPush/authorise. Também cobre resolução via banco, issuer diferente/sem OIDC (sem vínculo) e [REDACTED SECRET] via roleMapping. test/testDb.test.ts: createUser com oidcId → findUserByOIDC encontra o usuário.

⚠️ Mudança de contrato da API: clientes JWT que dependiam de uma claim [REDACTED SECRET]/username no token perdem esses direitos. Admin deve ser configurado em roleMapping; para aprovar/rejeitar/cancelar pushes, o sub do token precisa estar ligado a um usuário GitProxy (oidcId). Sessões locais/OIDC/AD não mudam.

Como testar:

npm ci
npx vitest --run test/testJwtAuthHandler.test.ts test/testPush.test.ts
npm run lint && npm run check-types

Related Issue

Code scan finding sfind-072118d306f4438fa97c4da854ce3f0d (sem issue no GitHub).

Checklist

General

Documentation

  • Documentation has been added/updated for any new features

Configuration

  • If configuration schema (config.schema.json) was modified: (não modificado)

Tests

  • Tests have been added/updated for new functionality
  • Unit tests pass (npm test) — CI (Mongo 6.0/7.0, Node 22/24): 774 testes passam, incluindo os novos; as 2 falhas são em test/ConfigLoader.test.ts (loadRemoteConfig carrega proxy.config.json de finos/git-proxy main, que agora tem sink incompatível) e também ocorrem no PR fix(oidc): persist OIDC subject and avoid email local-part username collisions #43. Jobs Mongo 8.0 falham porque o container mongo:8.0 não inicia.
  • Linting and formatting pass (npm run lint and npm run format:check) — job Linting verde no CI
  • Type checks pass (npm run check-types) — ver CI

Devin-Org: engineering

Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/e1ad79e6e2974f2e9aa6e7137f134960
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/e1ad79e6e2974f2e9aa6e7137f134960?variant=devin


Devin Review

Status Commit
⚪ Not started —

Run Devin Review

Enable auto-review to review your pull requests automatically.

Devin Review (Staging)


Devin Review

The JWT API auth handler assigned the verified token payload directly to
req.user, so admin/username claims in the token were trusted for
authorization. req.user is now a fresh object: admin starts false and is
only set by roleMapping, and username/email come from the user database
(matched on the token sub via oidcId). Push approve/reject/cancel return
403 when no linked username is present.

Fixes code scan finding sfind-072118d306f4438fa97c4da854ce3f0d.

Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

devin-ai-integration[bot]

This comment was marked as resolved.

…bject

Addresses Devin Review on #33: createUser accepted an oidcId but dropped it
from the stored record, so findUserByOIDC (used by OIDC login and now by
the JWT handler) never matched OIDC-created users.

Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration[bot]

This comment was marked as resolved.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None


const app = express();
app.use(express.json());
app.use(jwtAuthHandler(jwtConfig));
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant