Skip to content

fix: use new preset type #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ConnorNeed merged 1 commit into from
Aug 2, 2026
Merged

fix: use new preset type #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 25 additions & 14 deletions src/components/VideoPresetsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ type VideoPreset = {
sources: VideoSource[];
}

type VideoPresetsMessage = {
presets: VideoPreset[];
}

const VideoPresetsPanel: React.FC<VideoPresetsPanelProps> = ({
onPresetSelect,
}) => {
Expand All @@ -31,23 +35,30 @@ const VideoPresetsPanel: React.FC<VideoPresetsPanelProps> = ({
});

useEffect(() => {
if (!ros) {
console.error("ROS connection is not established.");
if (!ros || rosStatus !== "connected") {
setPresets([]);
return;
}
const getPresetsClient = new ROSLIB.Service({
ros: ros,
name: "/list_presets",
serviceType: "interfaces/srv/GetPresets",
});

const request = new ROSLIB.ServiceRequest({});
getPresetsClient.callService(request, (response) => {
if (response) {
setPresets(response.presets);
}
const presetsTopic = new ROSLIB.Topic({
ros,
name: "/video_presets",
messageType: "interfaces/msg/VideoPresets",
queue_size: 1,
});
}, [ros]);

const handlePresets = (message: ROSLIB.Message) => {
const presetsMessage = message as unknown as VideoPresetsMessage;
setPresets(presetsMessage.presets ?? []);
};

presetsTopic.subscribe(handlePresets);

return () => {
presetsTopic.unsubscribe(handlePresets);
};
}, [ros, rosStatus]);

return (
<div
style={{
Expand All @@ -70,4 +81,4 @@ const VideoPresetsPanel: React.FC<VideoPresetsPanelProps> = ({
);
};

export default VideoPresetsPanel;
export default VideoPresetsPanel;
Loading