Skip to content

Complete modernization steps 2.3C and 2.3D - #57

Merged
egull merged 9 commits into
modernize/step2from
modernize/step2.3c
Sep 24, 2026
Merged

egull merged 9 commits into
modernize/step2from
modernize/step2.3c

Conversation

@egull

@egull egull commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • return a failure status for command errors and report standard exceptions with e.what()
  • accept the documented half-lorentzian spelling and correct the grid help text
  • add a reproducible bootstrap SEED parameter, defaulting to 0, with regression coverage
  • apply the time-bosonic zero-frequency limit only at exactly zero frequency
  • keep logarithmic-grid calculations in double precision
  • retain JacobiSVD after benchmarking BDCSVD and finding no speedup

Validation

  • 41/41 Release unit tests pass
  • complete fast regression suite passes
  • complete full regression suite passes
  • Debug warnings-as-errors build passes
  • bootstrap output is identical across independent runs with the default seed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unknown Maxent exceptions can currently be recorded as passing regression cases.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 High severity

Open (2)
What changed in this PR

This PR modernizes Maxent CLI behavior, bootstrap reproducibility, grid handling, numerical edge cases, and regression coverage.

Changes:

  • Adds deterministic bootstrap seeding and updated regression references.
  • Corrects grid aliases, help text, zero-frequency handling, and log-grid precision.
  • Improves exception status handling and expands documentation and tests.
  • Regression classification still needs to record unknown Maxent failures correctly.
File Description
test/​regression/​REFERENCE_CHANGES.md Records updated regression references.
test/​regression/​README.md Documents deterministic bootstrap output.
test/​regression/​PROVENANCE.md Records bootstrap and kernel provenance.
test/​regression/​manifest.py Updates generated manifest rules.
test/​regression/​MANIFEST.md Updates the case inventory.
test/​regression/​make_inputs.py Generates bootstrap test inputs.
test/​regression/​inputs/​t_grid_half_lorentzian/​case.param Uses the hyphenated grid alias.
test/​regression/​inputs/​t_generate_err/​data.dat Adds bootstrap input data.
test/​regression/​inputs/​t_generate_err/​case.param Adds bootstrap case parameters.
test/​regression/​generate.py Packs bootstrap output and classifies run statuses.
test/​regression/​components/​dump_components.cpp Adds symmetric kernel coverage.
test/​regression/​cases.py Registers updated regression cases.
test/​gridTest.cpp Tests the grid alias.
src/​maxent.hpp Stores the bootstrap seed.
src/​maxent.cpp Adds exception handling and corrected help text.
src/​maxent_simulation.cpp Defines the SEED parameter.
src/​maxent_kernel.cpp Applies the precise zero-frequency limit.
src/​maxent_helper.cpp Uses the configured bootstrap seed.
src/​maxent_grid.cpp Supports the alias and preserves double precision.
ALPS3_MIGRATION_PLAN.md Marks modernization steps complete.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/maxent.cpp Outdated
Comment thread test/regression/generate.py Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Strengthen non-default seed coverage, correct provenance counts, and require the expected exception signature in regression classification.

Review effort: Lite
Findings: None

Resolved since last review (2)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Three moderate regression-validation issues remain unresolved.

Review effort: Lite
Findings: None

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues are recorded, and the supplied validation passes.

Review effort: Lite
Findings: None

@egull
egull merged commit c311f8b into modernize/step2 Sep 24, 2026
1 check passed
@egull
egull deleted the modernize/step2.3c branch September 24, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants