Complete modernization steps 2.3C and 2.3D - #57
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unknown Maxent exceptions can currently be recorded as passing regression cases.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
This PR modernizes Maxent CLI behavior, bootstrap reproducibility, grid handling, numerical edge cases, and regression coverage.
Changes:
- Adds deterministic bootstrap seeding and updated regression references.
- Corrects grid aliases, help text, zero-frequency handling, and log-grid precision.
- Improves exception status handling and expands documentation and tests.
- Regression classification still needs to record unknown Maxent failures correctly.
| File | Description |
|---|---|
test/regression/REFERENCE_CHANGES.md |
Records updated regression references. |
test/regression/README.md |
Documents deterministic bootstrap output. |
test/regression/PROVENANCE.md |
Records bootstrap and kernel provenance. |
test/regression/manifest.py |
Updates generated manifest rules. |
test/regression/MANIFEST.md |
Updates the case inventory. |
test/regression/make_inputs.py |
Generates bootstrap test inputs. |
test/regression/inputs/t_grid_half_lorentzian/case.param |
Uses the hyphenated grid alias. |
test/regression/inputs/t_generate_err/data.dat |
Adds bootstrap input data. |
test/regression/inputs/t_generate_err/case.param |
Adds bootstrap case parameters. |
test/regression/generate.py |
Packs bootstrap output and classifies run statuses. |
test/regression/components/dump_components.cpp |
Adds symmetric kernel coverage. |
test/regression/cases.py |
Registers updated regression cases. |
test/gridTest.cpp |
Tests the grid alias. |
src/maxent.hpp |
Stores the bootstrap seed. |
src/maxent.cpp |
Adds exception handling and corrected help text. |
src/maxent_simulation.cpp |
Defines the SEED parameter. |
src/maxent_kernel.cpp |
Applies the precise zero-frequency limit. |
src/maxent_helper.cpp |
Uses the configured bootstrap seed. |
src/maxent_grid.cpp |
Supports the alias and preserves double precision. |
ALPS3_MIGRATION_PLAN.md |
Marks modernization steps complete. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
e.what()half-lorentzianspelling and correct the grid help textSEEDparameter, defaulting to 0, with regression coverageJacobiSVDafter benchmarkingBDCSVDand finding no speedupValidation