fix: use release start timestamp for delta zip filename - #63
Open
maksimtech wants to merge 1 commit into
Open
Conversation
The timestamp for the delta filename was captured with new Date() inside DeltaCommand.run(), which captures the time of execution rather than the release start time. If processing crosses an hour boundary, the filename ends up one hour ahead of the release tag (e.g. tag cve_2026-01-29_0200Z contains a file named 2026-01-29_delta_CVEs_at_0300Z.zip). Fix: derive timestamp from options.start (the release start time) instead of new Date() at execution time. Fixes #124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The delta zip filename was derived from
new Date()insideDeltaCommand.run(), which captures the time when the functionexecutes rather than when the release started.
If processing crosses an hour boundary the filename ends up one hour
ahead of the release tag (e.g. tag
cve_2026-01-29_0200Zcontainsa file named
2026-01-29_delta_CVEs_at_0300Z.zip).Fixes #124.
Fix
Replace
new Date()withnew Date(options.start)so the filenamealways reflects the release start time:
Notes
The
--yesterday-allbranch already handles this correctly usingstartOfYesterday()— this fix brings the default branch in linewith the same approach.
This fix is equivalent to the approach in PR #130.