test: add Pest v1 security test infrastructure - #95
Open
somethingwithproof wants to merge 4 commits into
Open
somethingwithproof wants to merge 4 commits into
somethingwithproof wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a Pest-based security test scaffold for the MikroTik plugin, aiming to add lightweight static checks over key plugin files without requiring a full Cacti runtime.
Changes:
- Adds a Pest bootstrap/config entrypoint (
tests/Pest.php,tests/bootstrap.php) with basic Cacti function stubs. - Adds security-oriented Pest tests to validate
setup.phpstructure, enforce prepared-statement usage, and guard against PHP 8+ syntax usage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Security/SetupStructureTest.php | Adds assertions about required setup.php functions and version metadata presence. |
| tests/Security/PreparedStatementConsistencyTest.php | Adds a static scan intended to forbid raw db_execute/db_fetch_* calls. |
| tests/Security/Php74CompatibilityTest.php | Adds static scans for a small set of PHP 8.0+ syntax/API usage. |
| tests/Pest.php | Adds Pest entrypoint requiring the test bootstrap. |
| tests/bootstrap.php | Adds a test bootstrap with stubs for selected Cacti/DB helper functions/constants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
somethingwithproof
force-pushed
the
test/security-test-infrastructure
branch
from
July 14, 2026 10:46
55f0a23 to
325045a
Compare
xmacan
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the Pest security test infrastructure into its own PR as requested.