Skip to content

test: add Pest v1 security test infrastructure - #95

Open
somethingwithproof wants to merge 4 commits into
Cacti:developfrom
somethingwithproof:test/security-test-infrastructure
Open

somethingwithproof wants to merge 4 commits into
Cacti:developfrom
somethingwithproof:test/security-test-infrastructure

Conversation

@somethingwithproof

Copy link
Copy Markdown
Member

Separates the Pest security test infrastructure into its own PR as requested.

Copilot AI review requested due to automatic review settings April 11, 2026 23:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a Pest-based security test scaffold for the MikroTik plugin, aiming to add lightweight static checks over key plugin files without requiring a full Cacti runtime.

Changes:

  • Adds a Pest bootstrap/config entrypoint (tests/Pest.php, tests/bootstrap.php) with basic Cacti function stubs.
  • Adds security-oriented Pest tests to validate setup.php structure, enforce prepared-statement usage, and guard against PHP 8+ syntax usage.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/Security/SetupStructureTest.php Adds assertions about required setup.php functions and version metadata presence.
tests/Security/PreparedStatementConsistencyTest.php Adds a static scan intended to forbid raw db_execute/db_fetch_* calls.
tests/Security/Php74CompatibilityTest.php Adds static scans for a small set of PHP 8.0+ syntax/API usage.
tests/Pest.php Adds Pest entrypoint requiring the test bootstrap.
tests/bootstrap.php Adds a test bootstrap with stubs for selected Cacti/DB helper functions/constants.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/Security/SetupStructureTest.php Outdated
Comment thread tests/Security/SetupStructureTest.php Outdated
Comment thread tests/Security/PreparedStatementConsistencyTest.php Outdated
Comment thread tests/Security/PreparedStatementConsistencyTest.php Outdated
Comment thread tests/Security/Php74CompatibilityTest.php Outdated
@somethingwithproof
somethingwithproof force-pushed the test/security-test-infrastructure branch from 55f0a23 to 325045a Compare July 14, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants