perf: open_snapshot no longer loads the full inventory blob - #1
Merged
Merged
Conversation
Opening a snapshot rehydrated the entire inventory (tens of MB at 100k+) just to recover the class list, so open time scaled with dataset size (231ms@100k -> 764ms@300k). Store the class list directly in the small vN.json payload and read the record without rehydrating the inventory. Measured: open is now 3-7ms and flat across 100k/200k/300k (was 231/403/764ms). Old snapshots without the classes field fall back to the inventory blob. diff/show still rehydrate as before. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a snapshot rehydrated the entire inventory (tens of MB at 100k+)
just to recover the class list, so open time scaled with dataset size
(231ms@100k -> 764ms@300k). Store the class list directly in the small
vN.json payload and read the record without rehydrating the inventory.
Measured: open is now 3-7ms and flat across 100k/200k/300k (was
231/403/764ms). Old snapshots without the classes field fall back to the
inventory blob. diff/show still rehydrate as before.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com