Skip to content

fix(cli): stop canyonos test from starting the dashboard stack - #169

Open
userAugustos wants to merge 1 commit into
mainfrom
fix/test-no-dashboard-serve
Open

userAugustos wants to merge 1 commit into
mainfrom
fix/test-no-dashboard-serve

Conversation

@userAugustos

@userAugustos userAugustos commented Sep 21, 2026 •

Copy link
Copy Markdown

Follow-up from the #103 review thread on the dashboard under canyonos test.

_deploy_locally passed serve=True to run_deploy, kept by a comment saying the dashboard's LLM proxy was needed "for code that calls it directly". Since #112 agents proxy their LLM calls in-container (127.0.0.1:8081, see llm_proxy_env.py), and the dashboard stack is only db / api / web — nothing a smoke test reads. Every canyonos test was still paying for it:

  • two ghcr.io image pulls
  • docker compose up -d --wait (up to 180 s)
  • a rewrite of the project's .env (CANYONOS_JWT_SECRET, CANYONOS_WEB_PORT, …) that was never restored

Change

  • packages/cli/canyonos/test.py — serve=False in _deploy_locally, comment rewritten to say why the dashboard is not started.
  • packages/cli/tests/test_canyonos_test.py — one test pinning serve=False, so the flag can't drift back.

--real-llm is unaffected: it never went through the dashboard.

Verification

Same recipe as ci.yml, locally:

bun run check : lint / typecheck / format:check — 3 successful
bun run test  : canyonos 156 passed (155 + the new one)
                canyonos-core 257 passed, 1 skipped
                canyonos-python 15 passed

Summary by CodeRabbit

  • Bug Fixes
    • Smoke tests no longer start the dashboard stack or its LLM proxy.
    • Agent LLM calls continue to be handled within the test environment.
  • Tests
    • Added coverage to verify that smoke tests run without starting the dashboard.

`_deploy_locally` passed `serve=True` to `run_deploy`, kept by a comment
saying the dashboard's LLM proxy was needed "for code that calls it
directly". Since #112 agents proxy their LLM calls in-container
(127.0.0.1:8081), and the dashboard stack is only db/api/web -- nothing a
smoke test reads. Every `canyonos test` was still paying for it: two image
pulls, a `compose up --wait`, and a rewrite of the project's `.env` that
was never restored.

Pass `serve=False` and pin it with a test so the flag can't drift back.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LhMfuJ2Fa6HpCT8zCPgYwQ
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 91c2180c-daad-41c6-aeb5-39c22b900939

📥 Commits

Reviewing files that changed from the base of the PR and between 487b224 and fd824dd.

📒 Files selected for processing (2)
  • packages/cli/canyonos/test.py
  • packages/cli/tests/test_canyonos_test.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The local deploy phase of canyonos test now passes serve=False to run_deploy. A test verifies that the dashboard is not started during the smoke test.

Changes

Smoke test deployment

Layer / File(s) Summary
Disable dashboard during test deploy
packages/cli/canyonos/test.py, packages/cli/tests/test_canyonos_test.py
_deploy_locally passes serve=False to run_deploy. The test verifies the argument and confirms that run_test("hi") returns 0.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: preventing canyonos test from starting the dashboard stack.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant