fix(cli): stop canyonos test from starting the dashboard stack - #169
userAugustos wants to merge 1 commit into
Conversation
`_deploy_locally` passed `serve=True` to `run_deploy`, kept by a comment saying the dashboard's LLM proxy was needed "for code that calls it directly". Since #112 agents proxy their LLM calls in-container (127.0.0.1:8081), and the dashboard stack is only db/api/web -- nothing a smoke test reads. Every `canyonos test` was still paying for it: two image pulls, a `compose up --wait`, and a rewrite of the project's `.env` that was never restored. Pass `serve=False` and pin it with a test so the flag can't drift back. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LhMfuJ2Fa6HpCT8zCPgYwQ
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe local deploy phase of ChangesSmoke test deployment
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up from the #103 review thread on the dashboard under
canyonos test._deploy_locallypassedserve=Truetorun_deploy, kept by a comment saying the dashboard's LLM proxy was needed "for code that calls it directly". Since #112 agents proxy their LLM calls in-container (127.0.0.1:8081, seellm_proxy_env.py), and the dashboard stack is onlydb/api/web— nothing a smoke test reads. Everycanyonos testwas still paying for it:ghcr.ioimage pullsdocker compose up -d --wait(up to 180 s).env(CANYONOS_JWT_SECRET,CANYONOS_WEB_PORT, …) that was never restoredChange
packages/cli/canyonos/test.py—serve=Falsein_deploy_locally, comment rewritten to say why the dashboard is not started.packages/cli/tests/test_canyonos_test.py— one test pinningserve=False, so the flag can't drift back.--real-llmis unaffected: it never went through the dashboard.Verification
Same recipe as
ci.yml, locally:Summary by CodeRabbit