Fix malformed-JSON handling and undefined error_message (CAN-290, CAN-291) - #82
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 9 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nickhuo
marked this pull request as ready for review
September 9, 2026 22:33
- deploy.py: POST /<workflow> silently coerced a malformed JSON body to
{} via get_json(force=True, silent=True), dispatching the request
anyway and surfacing a misleading "missing positional argument"
error from the workflow function instead of the real parse problem.
Now rejects a non-empty, invalid/non-object body with 400 and the
actual JSON decode error; an empty body still defaults to {} for
all-default-arg workflows.
- local_controller_frontend.py: WriteResult referenced an undefined
error_message when relaying a result to on_result(), throwing on
every successful write and logging a misleading "WriteResult failed"
error after the result had already been persisted. error_message is
now read from the same "error" field _send_result_callback sends.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
nickhuo
force-pushed
the
nickhuo/fix-error-msg-issues
branch
from
September 9, 2026 22:38
ef79a98 to
69e27fe
Compare
iidsample
reviewed
Sep 10, 2026
iidsample
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAN-290: POST / used to treat broken JSON as if it were empty {} and keep going. That meant the real problem was hidden, and you’d only see a confusing “missing argument” error later in /status.
Now it behaves properly:
CAN-291: WriteResult was trying to read an undefined variable called error_message after the result had already been written successfully. That caused a NameError and made the logs say WriteResult failed even though the write actually succeeded.
Now it reads the error from data.get("error", ""), which matches what the callback actually sends