Detect the .car layout on the host the way the runtime does - #93
Draft
userAugustos wants to merge 1 commit into
Draft
userAugustos wants to merge 1 commit into
userAugustos wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
userAugustos
marked this pull request as draft
September 10, 2026 21:42
userAugustos
force-pushed
the
userAugustos/can-334-layout-detection
branch
from
September 11, 2026 18:18
fcd5001 to
17497de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs CAN-334, finding 12.
The host CLI picked the
.carlayout by checking for the config file, while the runtime (_artifact_prefix, the global controller, the server) picks it by the presence of the.cardirectory. A project with a.cardirectory but no config in it, for example after an interruptedcanyonos build, made the host read the legacy root config while the container insisted on the.carone, and deploy failed with a 400 naming a path that exists on the host.default_config_path()now keys on the.cardirectory, same as the runtime, and always returns the path soserveandstatus, which only read ports, keep working in a half-built project.missing_config_message()gives one wording;config,deploy, andtestuse it.deployrefuses beforerun_init()so a project with nothing to deploy does not tear down a running one.testraises it becauserun_testrenders failures itself and would otherwise report success under--json.Tests:
PYTHONPATH=cli:grpc_stubs:canyonos_core/controller/utils pytest tests/ -q→ 283 passed, 6 failed. All 6 failures reproduce identically onorigin/main: the 3CliDeployTestspatch the globalos.path.isfile, which makesresolve_env_filesee the platform secrets file, and the 3InstanceManagerRuntimeTestspatch a_port_boundattribute that no longer exists.