Repository navigation
Conversation
Add a "12H Clock" toggle under Date & Time in the APPLaunch settings tree, backed by the shared CP0_CONFIG_KEY_CLOCK_12H config key so the setting and its presentation cannot drift apart. The preference is read with GetInt, written with SetInt plus Save, and rolled back when Save fails. cp0_time_str() keeps its documented 24-hour "HH:MM" contract because the Date & Time page parses that value. A new cp0::time::format_12_hour() helper only reformats the presentation to "h:MM AM/PM", and the top bar pill switches to a wider background asset to fit the longer text. Add unit tests for the formatter and contract tests for the setting, the shared config key, the persistence rollback, and the wide pill asset.
- Point APPLaunch SSH deploy host to the new device IP
- Use {password}/{remote_file_path} placeholders in deploy after_cmd
- Add cp0_time_format.cpp to CardputerZero-Emulator sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "12H Clock" toggle under Date & Time in the APPLaunch settings tree, backed by the shared CP0_CONFIG_KEY_CLOCK_12H config key so the setting and its presentation cannot drift apart. The preference is read with GetInt, written with SetInt plus Save, and rolled back when Save fails.
cp0_time_str() keeps its documented 24-hour "HH:MM" contract because the Date & Time page parses that value. A new cp0::time::format_12_hour() helper only reformats the presentation to "h:MM AM/PM", and the top bar pill switches to a wider background asset to fit the longer text.
Add unit tests for the formatter and contract tests for the setting, the shared config key, the persistence rollback, and the wide pill asset.