Repository navigation
refactor(settings): format RTC local time with strftime - #251
Merged
Merged
Conversation
Replace the hand-rolled std::snprintf format string in settings_rtc_local_time_text() with std::strftime using the equivalent "%Y-%m-%d %H:%M:%S" format, dropping the per-field tm_year/tm_mon conversions. Output is unchanged, and with an int tm_year the longest possible string is 25 characters, so the 32-byte buffer cannot truncate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hand-rolled std::snprintf format string in settings_rtc_local_time_text() with std::strftime using the equivalent "%Y-%m-%d %H:%M:%S" format, dropping the per-field tm_year/tm_mon conversions. Output is unchanged, and with an int tm_year the longest possible string is 25 characters, so the 32-byte buffer cannot truncate.