Repository navigation
fix(brief): hold the zero-click line for a week after the post's copy changes - #257
Merged
Merged
Conversation
… changes The 2026-10-09 brief re-indicted a title that had been replaced the previous morning: the impressions the line reads come from the latest exported Search Console day, itself about two days behind, and the prerendered page only picks a new title up at the next nightly build. The ledger-based hold covers wave-reviewed pairs only; this covers the title and description writes made outside the wave, which never reach the ledger. A post that cannot be looked up keeps its line. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018TZ47Z87n82qtcAceHeEyn
miquelmatoses
force-pushed
the
maint/daily-2026-10-10
branch
from
October 15, 2026 05:51
a588ec7 to
7d5b451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What fired and why it should not have
The 2026-10-09 brief's zero-click line indicted the title of
/blog/history-of-the-big-five-from-allport-to-goldberg/, which had been rewritten in D1 the previous morning (blog_posts.updated_at2026-10-09T05:14Z). The line could only re-indict copy that was already replaced:The fix
holdFreshlyEdited(db, search)drops the zero-click candidate when the post'supdated_atis younger thanZERO_CLICK_EDIT_HOLD_DAYS(7 days). After a week the exported data is looking at the new copy and silence is a finding again.This complements, rather than overlaps, the ledger-based hold in #255: that one covers pairs the wave reviewed (read from the ledger), this one covers the title and description writes made outside the wave, which never reach the ledger. The two changes touch different functions and merge cleanly in either order.
Failure-safe direction: a post that cannot be looked up (missing row, unreadable table, null
updated_at) keeps its line, so a lookup defect can never silence a real finding. Non-blog URLs pass through untouched.npx vitest run: 533 passed, including 4 new tests for the hold.🤖 Generated with Claude Code
https://claude.ai/code/session_018TZ47Z87n82qtcAceHeEyn
Generated by Claude Code