Repository navigation
Conversation
Create the adapter when the processor is constructed and always register required properties when the service starts, including with an injected test client.
Gate transactions on startup cleanup while keeping cancellation local to each transaction. Track startup commit waiters so shutdown can cancel them without cancelling the cleanup worker. Wait for startup and active commit workers before stop-time cleanup, reject commits after stopping, and prevent restart until shutdown completes. Include deterministic regression tests for ordering, cancellation, failures, and repeated service starts.
Move cleanup coverage into a dedicated module and exercise receiver isolation, empty results, query batches, transient failures, capped backoff, and bounded shutdown retries.
jacomago
force-pushed
the
clean-lock
branch
3 times, most recently
from
October 12, 2026 06:27
40f4423 to
e688923
Compare
Add property_value() for canonical and custom property names, and has_property() for name-only checks or exact CFProperty matches. Cover enum and string names, missing properties, empty and None values, exact matches, and first-match lookup semantics.
Add CFChannel.property() for canonical and custom names. Reuse it for value and name-existence lookups while preserving exact-property matching.
jacomago
force-pushed
the
clean-lock
branch
2 times, most recently
from
October 12, 2026 08:45
4350986 to
6b1a649
Compare
Keep the IOC running across a hard receiver restart. Require fresh timestamps on every live channel and verify that a seeded stale channel becomes Inactive. Use the shared adapter fixture and typed status properties, and restore the receiver if the test leaves it stopped.
|
jacomago
marked this pull request as ready for review
October 12, 2026 13:51
jacomago
requested review from
anderslindho,
shroffk,
simon-ess and
tynanford
October 12, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at fixing that the clean was happening in the background of commits going on, leading to a race between setting a channel status to inactive for the clean and active for the commits.
Also some refactoring of processor by taking advantage of adding some helper methods to the cf/model, because... I like refactoring :)