Repository navigation
Conversation
Unfortunately this gets caught on every channel after a restart since the iocid is different (host:port) in each case. This would _flood_ the info level logs for a typical IOC restart. Note that the log was being done twice, once before the call to _update_existing_channel_diff_iocid and once during.
jacomago
approved these changes
Oct 13, 2026
Iterating over records then env vars meant (due to increased logging) that we logged _every_ record/env var combination. This change means that we log each environment variable that is missing only a single time.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately this gets caught on every channel after a restart since the iocid is different (host:port) in each case. This would flood the info level logs for a typical IOC restart.
Note that the log was being done twice, once before the call to _update_existing_channel_diff_iocid and once during.