Add real app health check - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a real application-level health check that validates critical dependencies instead of returning a static placeholder response. It checks database connectivity and Redis availability and exposes the result through the main
/api/healthendpoint.Related Issues
N/A
Type of Change
Changes
app.service.tsthat:SELECT 1against the TypeORM data sourceREDIS_CLIENTokwhen both dependencies are healthy, otherwisedegradedapp.controller.tsto serve the asynchronous health response at/api/healthapp.service.spec.tscovering:Checklist
npm run lintpasses.npx tsc --noEmitpasses (no type errors).npm run buildsucceeds.npm testpasses, and I added/updated tests for my change where itmade sense.
stellarmoduleservices (no direct Horizon/RPC calls from feature modules).
Notes for Reviewers
This is a lightweight app health endpoint intended for load balancers or uptime checks. It is intentionally dependency-aware and returns per-service status for DB and Redis. It does not yet include more advanced checks for queue workers or external providers.