Skip to content

Reconcile DataSourceDesignSpace with platform API - #1058

Merged
kroenlein merged 1 commit into
mainfrom
maintain/reconcile-data-source-design-space
Aug 5, 2026
Merged

Reconcile DataSourceDesignSpace with platform API#1058
kroenlein merged 1 commit into
mainfrom
maintain/reconcile-data-source-design-space

Conversation

@kroenlein

@kroenlein kroenlein commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Add the descriptors field that the platform generates but that was being silently dropped during deserialization.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

Resolve a stash-pop conflict in DataSourceDesignSpace by keeping the
current DesignSubspace serialization (flat paths, Resource base), then
add the read-only `descriptors` field that the platform derives from the
data source but the client was not modeling.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@kroenlein
kroenlein requested a review from a team as a code owner August 5, 2026 17:08

@anoto-moniz anoto-moniz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kroenlein
kroenlein merged commit ddf263d into main Aug 5, 2026
38 checks passed
@kroenlein
kroenlein deleted the maintain/reconcile-data-source-design-space branch August 5, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants