Skip to content

[v5.0] Remove vestigial experimental fields from test fixture - #1059

Merged
kroenlein merged 1 commit into
release/5.0from
maintain/remove-vestigial-test-fields
Aug 6, 2026
Merged

[v5.0] Remove vestigial experimental fields from test fixture#1059
kroenlein merged 1 commit into
release/5.0from
maintain/remove-vestigial-test-fields

Conversation

@kroenlein

@kroenlein kroenlein commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Drops the experimental and experimental_reasons keys from the shared generic_entity test fixture. These were removed from the SDK by PLA-9117 (2022) because the backend was hard-coding experimental to false.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in version.py

The `experimental` and `experimental_reasons` keys were removed from the
SDK by PLA-9117 (2022) once the backend began hard-coding them to false;
nothing in citrine deserializes them anymore. Drop them from the shared
generic_entity test fixture where they were left behind.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@kroenlein
kroenlein requested a review from a team as a code owner August 5, 2026 22:38
@kroenlein
kroenlein merged commit b267e8f into release/5.0 Aug 6, 2026
34 of 35 checks passed
@kroenlein
kroenlein deleted the maintain/remove-vestigial-test-fields branch August 6, 2026 15:09
anoto-moniz pushed a commit that referenced this pull request Aug 7, 2026
…igial-test-fields

[v5.0] Remove vestigial experimental fields from test fixture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants