Skip to content

SDK-5993: make vertical image corner radius and border configurable - #61

Open
reshab-code wants to merge 1 commit into
developfrom
task/add-border-radius-vertical-image
Open

SDK-5993: make vertical image corner radius and border configurable#61
reshab-code wants to merge 1 commit into
developfrom
task/add-border-radius-vertical-image

Conversation

@reshab-code

Copy link
Copy Markdown
Contributor

Summary

Made the vertical image corner radius, border color, and border width configurable via push payload keys (pt_img_corner_radius, pt_img_border_clr, pt_img_border_width). This mirrors the existing button border configuration pattern and allows templates to control image styling declaratively.

  • Added three optional payload keys to VerticalImageProperties
  • Moved hardcoded cornerRadius = 8.0 to configurable setting with 8pt default (preserves existing behavior)
  • Border only renders when pt_img_border_clr is provided; pt_img_border_width defaults to 1.0pt
  • Reuses existing FlexibleDouble decoder and UIColor(hex:) color parser

Test plan

Send vertical image push notifications with different payload configurations:

  • No image keys → image shows 8pt rounded corners, no border (regression)
  • pt_img_corner_radius: 20 → visibly rounder corners
  • pt_img_border_clr: "#FF0000", pt_img_border_width: 3 → red 3pt border
  • pt_img_corner_radius: "16" (string value) → confirm FlexibleDouble parsing
  • All three keys combined → full styling control

@shubhambjadhavar

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@reshab-code
reshab-code marked this pull request as ready for review August 10, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants