Repository navigation
fix: raise the dashboard watcher's default memory (128Mi limit, 64Mi request) - #327
Conversation
…request) At the 64Mi limit the kiwigrid/k8s-sidecar dashboard watcher was OOMKilled about once a minute on a kind cluster, with only 4 small dashboard ConfigMaps in one namespace: 3 restarts in 4 minutes, the pod never Ready, the initial sync never finished. With the limit at 128Mi its working set stayed at about 72Mi with a 95Mi peak, and it did not restart. So this is the sidecar's baseline, not load. The default limit becomes 128Mi (headroom above the measured peak) and the request 64Mi (about the measured working set, so the scheduler reserves what it uses). CPU is unchanged. The unit test for the default resources pins the new values; values.yaml says where the numbers come from. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016RAxvjuD1TdxneAHTCFpW8
🦋 Changeset detectedLatest commit: 25674bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deep Review✅ No critical issues found. This is a self-contained default-value bump (dashboard watcher memory: 🟡 P2 — recommended
🔵 P3 nitpicks (2)
Reviewers (4): correctness, testing, maintainability, project-standards. Testing gaps: none — the updated No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. |
At the 64Mi limit the kiwigrid/k8s-sidecar dashboard watcher was OOMKilled
about once a minute on a kind cluster, with only 4 small dashboard ConfigMaps
in one namespace: 3 restarts in 4 minutes, the pod never Ready, the initial
sync never finished. With the limit at 128Mi its working set stayed at about
72Mi with a 95Mi peak, and it did not restart. So this is the sidecar's
baseline, not load.
The default limit becomes 128Mi (headroom above the measured peak) and the
request 64Mi (about the measured working set, so the scheduler reserves what
it uses). CPU is unchanged. The unit test for the default resources pins the
new values; values.yaml says where the numbers come from.
Follow-up to #315, as discussed in its review.
🤖 Generated with Claude Code
https://claude.ai/code/session_016RAxvjuD1TdxneAHTCFpW8