Skip to content

Update appVersion to 2.46.0 - #328

Merged
teeohhem merged 2 commits into
mainfrom
update-app-version-2.46.0
Nov 18, 2026
Merged

teeohhem merged 2 commits into
mainfrom
update-app-version-2.46.0

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This PR updates the appVersion in Chart.yaml to 2.46.0 and aligns the otel-collector image tag in values.yaml.

  • Updated charts/clickstack/Chart.yaml
  • Updated otel-collector.image.tag in charts/clickstack/values.yaml
  • Regenerated charts/clickstack/README.md

@github-actions
github-actions Bot requested a review from a team as a code owner November 18, 2026 17:25
@changeset-bot

changeset-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 39ed896

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teeohhem
teeohhem enabled auto-merge (squash) November 18, 2026 19:05
@github-actions

Copy link
Copy Markdown
Contributor Author

Helm template coverage

Metric Value
Line coverage 99.86%
Branch coverage 90.91%
Line threshold 99% (met)
Branch threshold 90% (met)
Uncovered details

charts/clickstack/templates/NOTES.txt

Uncovered lines: none

Uncovered branches: 37:default:fallback

charts/clickstack/templates/_helpers.tpl

Uncovered lines: 17

Uncovered branches: 130:range:empty, 132:range:empty, 133:ternary:false, 16:if:true, 194:or(1):true, 211:range:empty, 242:default:fallback, 243:or(1):true, 259:if:false, 389:range:empty, 410:range:empty

charts/clickstack/templates/additional-manifests.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/clickhouse/cluster.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/clickhouse/keeper.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/configmap.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/cronjob-check-alerts.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/dashboard-configmap.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/dashboard-provisioner-rbac.yaml

Uncovered lines: none

Uncovered branches: 40:range:empty

charts/clickstack/templates/hyperdx/deployment.yaml

Uncovered lines: none

Uncovered branches: 121:default:fallback, 131:default:fallback, 196:default:fallback, 201:with:empty, 20:with:empty, 25:if:false, 26:default:fallback, 41:if:false, 42:with:empty

charts/clickstack/templates/hyperdx/hpa.yaml

Uncovered lines: none

Uncovered branches: 16:with:empty

charts/clickstack/templates/hyperdx/ingress.yaml

Uncovered lines: none

Uncovered branches: 15:with:empty, 35:if:false, 40:range:empty, 45:range:empty, 48:with:empty, 54:range:empty, 58:range:empty, 59:or(2):true, 59:or(3):true

charts/clickstack/templates/hyperdx/networkpolicy.yaml

Uncovered lines: none

Uncovered branches: 11:with:empty

charts/clickstack/templates/hyperdx/pdb.yaml

Uncovered lines: none

Uncovered branches: 10:with:empty

charts/clickstack/templates/hyperdx/secret.yaml

Uncovered lines: none

Uncovered branches: 1:or(2):true, 1:or(3):true

charts/clickstack/templates/hyperdx/service.yaml

Uncovered lines: none

Uncovered branches: 14:default:fallback, 9:with:empty

charts/clickstack/templates/hyperdx/serviceaccount.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/mongodb/community.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/mongodb/password-secret.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/otel-collector/custom-config.yaml

Uncovered lines: none

Uncovered branches: none

@github-actions

Copy link
Copy Markdown
Contributor Author

Deep Review

✅ No critical issues found. This is a clean version-bump PR. appVersion and the bundled otel-collector image tag both move 2.45.0 → 2.46.0 in lockstep, the README is a faithful helm-docs regeneration, and the changeset follows repo convention ("helm-charts": patch, matching the package name used by the other pending changesets).

Verification performed against the diff:

  • No stale 2.45.0 references remain in charts/ or tests/ — the only other occurrence is the historical CHANGELOG.md entry.
  • .Chart.AppVersion now defaults the HyperDX deployment image tag to 2.46.0; 2.46.0 still resolves to the final bin/hyperdx branch in cronjob-check-alerts.yaml (above the < 2.22.0 semver boundary), so no rendering path changes.
  • tests/hyperdx-rollout-checksums_test.yaml and tests/task-checkAlerts_test.yaml pin their own chart.appVersion overrides, so the bump does not invalidate their checksum or command assertions.
  • Chart version: 3.6.0 is intentionally left for the changeset tooling to bump at release; a patch changeset is appropriate since no templates changed.
  • Prior PR comments are bot-only (changeset-bot, helm coverage bot) with no human review threads requiring follow-up.

🟡 P2 -- recommended

  • charts/clickstack/values.yaml:500 -- The otel-collector image.tag must be hand-kept in sync with Chart.yaml appVersion, and no helm-unittest asserts they match, so a future bump can silently drift one value.
    • Fix: Add a unit test asserting the rendered otel-collector image tag equals .Chart.AppVersion, or template the tag from appVersion to remove the duplicated source of truth.
    • testing, maintainability

Reviewers (4): correctness, testing, project-standards, previous-comments.

Testing gaps: No automated guard couples otel-collector.image.tag to Chart.yaml appVersion; the two are kept aligned only by manual edits in version-bump PRs like this one.

No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR.

@teeohhem
teeohhem merged commit 6403f07 into main Nov 18, 2026
10 checks passed
@teeohhem
teeohhem deleted the update-app-version-2.46.0 branch November 18, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants